Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     Kevin Yang <kevin_yang@realtek.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/6] wifi: rtw89: mac: process MCC related C2H
In-Reply-To: <6444fb9949e14656b3ccf0adb6babb63@realtek.com> (Ping-Ke Shih's
        message of "Tue, 29 Nov 2022 00:22:40 +0000")
References: <20221118051042.29968-1-pkshih@realtek.com>
        <20221118051042.29968-5-pkshih@realtek.com>
        <87o7sr5hq9.fsf@kernel.org>
        <6444fb9949e14656b3ccf0adb6babb63@realtek.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Date:   Tue, 29 Nov 2022 07:35:10 +0200
Message-ID: <8735a25nn5.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Ping-Ke Shih <pkshih@realtek.com> writes:

>> -----Original Message-----
>> From: Kalle Valo <kvalo@kernel.org>
>> Sent: Monday, November 28, 2022 9:31 PM
>> To: Ping-Ke Shih <pkshih@realtek.com>
>> Cc: Kevin Yang <kevin_yang@realtek.com>; linux-wireless@vger.kernel.org
>> Subject: Re: [PATCH 4/6] wifi: rtw89: mac: process MCC related C2H
>> 
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>> 
>> > From: Zong-Zhe Yang <kevin_yang@realtek.com>
>> >
>> > Process C2H(s) related to MCC (multi-channel concurrency). These handling,
>> > which either call rtw89_complete_cond() or show message in debug mode, can
>> > be considered atomic/lock-free. So, they should be safe to be processed
>> > directly after C2H pre-check in previous patch.
>> >
>> > Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
>> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>> 
>> [...]
>> 
>> > +static
>> > +void (* const rtw89_mac_c2h_mcc_handler[])(struct rtw89_dev *rtwdev,
>> > +					   struct sk_buff *c2h, u32 len) = {
>> > +	[RTW89_MAC_C2H_FUNC_MCC_RCV_ACK] = rtw89_mac_c2h_mcc_rcv_ack,
>> > +	[RTW89_MAC_C2H_FUNC_MCC_REQ_ACK] = rtw89_mac_c2h_mcc_req_ack,
>> > +	[RTW89_MAC_C2H_FUNC_MCC_TSF_RPT] = rtw89_mac_c2h_mcc_tsf_rpt,
>> > +	[RTW89_MAC_C2H_FUNC_MCC_STATUS_RPT] = rtw89_mac_c2h_mcc_status_rpt,
>> > +};
>> 
>> static const?
>> 
>
> These are function pointers, so const is before instance name, 
> i.e. '... const rtw89_mac_c2h_mcc_handler ..'

Ah indeed, missed that. Thanks.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches