Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp552645rwb; Tue, 29 Nov 2022 02:11:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf72ExogCOXne8GZZ2z9Ivoyv7DxpTahVqbT6nBEZlCEEbneLgzoCJkViEcBRA2S9pix3ueE X-Received: by 2002:a05:6402:68c:b0:461:b506:6b8a with SMTP id f12-20020a056402068c00b00461b5066b8amr51060644edy.208.1669716669655; Tue, 29 Nov 2022 02:11:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669716669; cv=none; d=google.com; s=arc-20160816; b=nX6wJPM4IuZrPmdC4AiG9vqI2XHBxuqt8s5KMcYL3fu/A8NmsP0h8E0QQ3zsMQ3m2L 7Rhuiffbz6KDYl7tJrx4vUALrXMpmBC7NWV3WjQeQsckesIVN3mfukb0kpTlKqGxpCkZ OCgJW6U3K7gXLScjgTSIQ1a4c3IK/GROj4vOX9wEd1rAJsg8SOqeFVCisrfB4/HgRsFg ZRdOY+GkxknA5DAJTCLBrdr4d89tUZuEJnAtx/S373CyYBC2WSnOS+2AjKcCnI/ze4ZD a5rtY3c9oBOXRH7KrgVJ9dG1NRvDy8RUyo/pJEZPYaqimK+7ByGV7Mt/GeHXf8HLpByb 3dUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=OorTeZY5veCZ5LS3K7Q06oRrQd7NMVlOQOChi1XNNZg=; b=bPnpDLb+turr50XlEpvxS7Wml2Yw6U8hdixiI1HU4tBH7TCj5Z/nSw/XMuxLWq2y8N 96iOthfQ3LlXuR/xSC9uh1NiuKWhjYlubzXOWpnR78B8v1DwgkIHkSB+7RWACdpiBAe0 gj4l4Wp4Oze/hqoA9ayCALHaq6ingeQMOgY3Ij11W/ccPhZF3pLSoBCbcWjqSuyfAO1d 7/1zNKUlkohBYmOm3ipo9aN5Z+6rB+5Y3boPvggDJd9AE55NbabB32icyP+EYPm6RXYy q9zMbvpl17gA0ES1jLSwjnM8X2Xj02hHZEWHq+EuHixrYHNUBRjO1H84H7tPSL2Of4qe rQaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s17-20020a056402521100b00463d1e2639fsi14344614edd.363.2022.11.29.02.10.49; Tue, 29 Nov 2022 02:11:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232111AbiK2KIJ (ORCPT + 67 others); Tue, 29 Nov 2022 05:08:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229899AbiK2KIH (ORCPT ); Tue, 29 Nov 2022 05:08:07 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EAB9140AF for ; Tue, 29 Nov 2022 02:08:06 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozxX1-0006y6-My; Tue, 29 Nov 2022 11:08:03 +0100 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1ozxWy-0012hq-8e; Tue, 29 Nov 2022 11:08:01 +0100 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1ozxWx-00BYGr-Cp; Tue, 29 Nov 2022 11:07:59 +0100 From: Sascha Hauer To: linux-wireless@vger.kernel.org Cc: Neo Jou , Hans Ulli Kroll , Ping-Ke Shih , Yan-Hsuan Chuang , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , kernel@pengutronix.de, Johannes Berg , Alexander Hochbaum , Da Xue , Po-Hao Huang , Viktor Petrenko , Sascha Hauer Subject: [PATCH v4 02/11] wifi: rtw88: Call rtw_fw_beacon_filter_config() with rtwdev->mutex held Date: Tue, 29 Nov 2022 11:07:45 +0100 Message-Id: <20221129100754.2753237-3-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221129100754.2753237-1-s.hauer@pengutronix.de> References: <20221129100754.2753237-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org rtw_fw_beacon_filter_config() is called once with rtwdev->mutex held and once without the mutex held. Call it consistently with rtwdev->mutex held. Signed-off-by: Sascha Hauer Reviewed-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c index 07578ccc4bab3..776a9a9884b5d 100644 --- a/drivers/net/wireless/realtek/rtw88/mac80211.c +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c @@ -487,8 +487,8 @@ static int rtw_ops_sta_remove(struct ieee80211_hw *hw, { struct rtw_dev *rtwdev = hw->priv; - rtw_fw_beacon_filter_config(rtwdev, false, vif); mutex_lock(&rtwdev->mutex); + rtw_fw_beacon_filter_config(rtwdev, false, vif); rtw_sta_remove(rtwdev, sta, true); mutex_unlock(&rtwdev->mutex); -- 2.30.2