Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1049974rwb; Tue, 29 Nov 2022 08:22:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf6MuRJSPeXzMUdemKhuP5P400tFsGBit3DW2+NcaH4aKZb99sSmvPYA06QhPyzPXeGtX4Od X-Received: by 2002:a62:84c5:0:b0:574:32ac:a47a with SMTP id k188-20020a6284c5000000b0057432aca47amr34470023pfd.7.1669738933340; Tue, 29 Nov 2022 08:22:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669738933; cv=none; d=google.com; s=arc-20160816; b=meuxM3nnP4PL0ryrYEuwXA8PWGogRl8YM59ztzDQEk3At2eteJ2Cb2jI2Xl9TYm1/c U7h1W5m2yhBBIds4t7NB+s4Jq6EARL2Wk+75BTByFcFVzYQrUnj7tcW4N/CKEmJLa/Vq x4XFGdfvVBFOgk1yBqGF9C4e+zJeq8JcCWEw7AUIuQVjWxqirUA5Jpc3rvNEIYbqHvaQ gOaY6bUPUFpfAeSwatW7ubYWAGsXELi2kDCm0XDO5vfx+q9RlQlzX6uMYWPmlCRizarl pKQ/NRTWzc3V1mheVVjBxDnn4jwA7ukhXmw9wbyYMPOksORTDDlNeykmiibyDOBmYvT5 eUkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=sto01ZHCAqmM1S/xXLulCpmkMcOmfml0hrIxJre8q6M=; b=iB7LutlfRJ3HCQ+mNleRCdE4+5JdCJPld1RJ3ZM2LLqwxF/YfIni1DUFDELV3SY463 avNOANinh63W3PnGTa2uw2lr2b3ZYtd2Aoe+Xwi84vYnd0ZPKUZnJNkwqbn7XI49MmfN eFPfFmYBNhqmtHlB9GD69jwrLlRLCtVo1QHRL+Qy51JfFc1cVYj68FAQRX381wft9Cad b9nD3sBCen6giG2GWQWllx8mH8g+J0uHdG2Yl4zU8e49di1Bjf8Ok49QlA1RJRveyjeY 9F+jBlOVsnDnBmabOBgjVqmWDBPN3INXASrKu522PuQK4RANvXr1Delb0PP32GDx1JK8 2vRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KvE7T2sl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i9-20020a170902c94900b00186b76f4655si16481905pla.358.2022.11.29.08.22.02; Tue, 29 Nov 2022 08:22:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KvE7T2sl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235874AbiK2QSP (ORCPT + 67 others); Tue, 29 Nov 2022 11:18:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235972AbiK2QSE (ORCPT ); Tue, 29 Nov 2022 11:18:04 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8877F2019F; Tue, 29 Nov 2022 08:17:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2A7A6B816AA; Tue, 29 Nov 2022 16:17:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B4A4C433D6; Tue, 29 Nov 2022 16:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669738674; bh=DRfn+TpVRUL6CMr5CTIyEdnUfSabuFcgLkGOasdBnL8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KvE7T2slbH5Il8SHhWyHYebElxnFHn47Y/mzxnpVTmdq1w6xY0W9iXXkSr8msjyWb c/8hSckKO9JBNOZ4+NicridH8+p1BnauSfEewGsi7Gk1I0YH1wEAJL+90yZFTiGwUA EjMP5XMX0ZU5zwJ2tizWh0CFBmuLKPVEK/71KCbis4pk8acTvN16YqZqyc3hpFHZNd M/DqhFDR2SVsr+x+wImVRQJkDjaUONQpvaFOBN+S7uNpvQQQEFcWVShUr5D27a/EOr XmLttSXUO4pULtEL4B8aZ8Gg2dq7zLVFuvkWC/xsYy4gl19F5xI3wbJTUIJFnVU8+t gIRQrjaLiuWxA== Date: Tue, 29 Nov 2022 08:17:53 -0800 From: Jakub Kicinski To: Sascha Hauer Cc: linux-wireless@vger.kernel.org, Neo Jou , Hans Ulli Kroll , Ping-Ke Shih , Yan-Hsuan Chuang , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , kernel@pengutronix.de, Johannes Berg , Alexander Hochbaum , Da Xue , Po-Hao Huang , Viktor Petrenko Subject: Re: [PATCH v4 08/11] wifi: rtw88: Add rtw8821cu chipset support Message-ID: <20221129081753.087b7a35@kernel.org> In-Reply-To: <20221129100754.2753237-9-s.hauer@pengutronix.de> References: <20221129100754.2753237-1-s.hauer@pengutronix.de> <20221129100754.2753237-9-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 29 Nov 2022 11:07:51 +0100 Sascha Hauer wrote: > +config RTW88_8821CU > + tristate "Realtek 8821CU USB wireless network adapter" > + depends on USB > + select RTW88_CORE > + select RTW88_USB > + select RTW88_8821C > + help > + Select this option will enable support for 8821CU chipset > + > + 802.11ac USB wireless network adapter Those kconfig knobs add so little code, why not combine them all into one? No point bothering the user with 4 different questions with amount to almost nothing.