Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <d2113f20-d547-ce16-ff7f-2d1286321014@lwfinger.net>
Date:   Tue, 29 Nov 2022 10:59:46 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v4 08/11] wifi: rtw88: Add rtw8821cu chipset support
To:     Jakub Kicinski <kuba@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>
Cc:     linux-wireless@vger.kernel.org, Neo Jou <neojou@gmail.com>,
        Hans Ulli Kroll <linux@ulli-kroll.de>,
        Ping-Ke Shih <pkshih@realtek.com>,
        Yan-Hsuan Chuang <tony0620emma@gmail.com>,
        Kalle Valo <kvalo@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        kernel@pengutronix.de, Johannes Berg <johannes@sipsolutions.net>,
        Alexander Hochbaum <alex@appudo.com>,
        Da Xue <da@libre.computer>, Po-Hao Huang <phhuang@realtek.com>,
        Viktor Petrenko <g0000ga@gmail.com>
References: <20221129100754.2753237-1-s.hauer@pengutronix.de>
 <20221129100754.2753237-9-s.hauer@pengutronix.de>
 <20221129081753.087b7a35@kernel.org>
Content-Language: en-US
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <20221129081753.087b7a35@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/29/22 10:17, Jakub Kicinski wrote:
> On Tue, 29 Nov 2022 11:07:51 +0100 Sascha Hauer wrote:
>> +config RTW88_8821CU
>> +	tristate "Realtek 8821CU USB wireless network adapter"
>> +	depends on USB
>> +	select RTW88_CORE
>> +	select RTW88_USB
>> +	select RTW88_8821C
>> +	help
>> +	  Select this option will enable support for 8821CU chipset
>> +
>> +	  802.11ac USB wireless network adapter
> 
> Those kconfig knobs add so little code, why not combine them all into
> one? No point bothering the user with 4 different questions with amount
> to almost nothing.

I see only one knob there, name RTW88_8821CU. The other configuration variables 
select parts of the code that are shared with other drivers such as RTW88_8821CE 
and these parts must be there.

Larry