Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Christoph Hellwig <hch@lst.de>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: ath11k vs ar_qrtr?
References: <20221130122807.GA31720@lst.de> <87o7so4nr2.fsf@kernel.org>
        <20221130125236.GA865@lst.de>
Date:   Wed, 30 Nov 2022 15:12:32 +0200
In-Reply-To: <20221130125236.GA865@lst.de> (Christoph Hellwig's message of
        "Wed, 30 Nov 2022 13:52:36 +0100")
Message-ID: <87k03c4mdb.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

+ linux-wireless

Christoph Hellwig <hch@lst.de> writes:

> On Wed, Nov 30, 2022 at 02:42:41PM +0200, Kalle Valo wrote:
>> Sorry, not following you here. Are you saying that "select QRTR" is not
>> enough and we should add something more?
>
> Yes, there is no runtime dependency right now. Something like using
> MODULE_SOFTDEP should solve this. Untested for now, but I can send a
> formal one after I make it past the initial installation:

Heh, I'm learning something new here. But I wonder why nobody else has
seen this?

If you submit a patch, please remember to CC linux-wireless so that our
patchwork sees it:

https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches

> diff --git a/drivers/net/wireless/ath/ath11k/core.c
> b/drivers/net/wireless/ath/ath11k/core.c
> index b99180bc81723b..72d043fc6b7c2c 100644
> --- a/drivers/net/wireless/ath/ath11k/core.c
> +++ b/drivers/net/wireless/ath/ath11k/core.c
> @@ -1945,3 +1945,5 @@ EXPORT_SYMBOL(ath11k_core_alloc);
>  
>  MODULE_DESCRIPTION("Core module for Qualcomm Atheros 802.11ax wireless LAN cards.");
>  MODULE_LICENSE("Dual BSD/GPL");
> +MODULE_SOFTDEP("pre: qrtr");
> +MODULE_SOFTDEP("pre: qrtr-mhi");

Would it be better to have these in one line?

MODULE_SOFTDEP("pre: qrtr qrtr-mhi");

At least the documentation seems to suggest that.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches