Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4f37f422a0bcd8d1d2dd1bb992be30a16d335a3f.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: mac80211: fix memory leak in
 ieee80211_register_hw()
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Zhengchao Shao <shaozhengchao@huawei.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com
Cc:     sara.sharon@intel.com, luciano.coelho@intel.com,
        weiyongjun1@huawei.com, yuehaibing@huawei.com
Date:   Thu, 01 Dec 2022 13:52:57 +0100
In-Reply-To: <20221122091142.261354-1-shaozhengchao@huawei.com>
References: <20221122091142.261354-1-shaozhengchao@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-11-22 at 17:11 +0800, Zhengchao Shao wrote:
>=20
> +++ b/net/mac80211/iface.c
> @@ -2326,8 +2326,6 @@ void ieee80211_remove_interfaces(struct ieee80211_l=
ocal *local)
>  	WARN(local->open_count, "%s: open count remains %d\n",
>  	     wiphy_name(local->hw.wiphy), local->open_count);
> =20
> -	ieee80211_txq_teardown_flows(local);


This is after shutting down interfaces.

> @@ -1469,6 +1470,7 @@ void ieee80211_unregister_hw(struct ieee80211_hw *h=
w)
>  	 * because the driver cannot be handing us frames any
>  	 * more and the tasklet is killed.
>  	 */
> +	ieee80211_txq_teardown_flows(local);
>  	ieee80211_remove_interfaces(local);
>=20

But now it's before. Why is that safe?

johannes