Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a5ac1a2e09096280f56c657e966c728ca8e176a0.camel@sipsolutions.net>
Subject: Re: [PATCH net] wifi: mac80211: fix WARNING in
 ieee80211_link_info_change_notify()
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Zhengchao Shao <shaozhengchao@huawei.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com
Cc:     weiyongjun1@huawei.com, yuehaibing@huawei.com
Date:   Thu, 01 Dec 2022 15:14:46 +0100
In-Reply-To: <20221104110856.364410-1-shaozhengchao@huawei.com>
References: <20221104110856.364410-1-shaozhengchao@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-11-04 at 19:08 +0800, Zhengchao Shao wrote:
>=20
> The execution process is as follows:
> Thread A:
> ieee80211_open()
>     ieee80211_do_open()
>         drv_add_interface()     //set IEEE80211_SDATA_IN_DRIVER flag
> ...
> cfg80211_shutdown_all_interfaces()
>     ...
>     ieee80211_stop()
>         ieee80211_do_stop()
>             drv_remove_interface() //clear flag
> ...
> nl80211_set_mcast_rate()

How is that possible after the interface is no longer running? That
seems to be the issue? I suppose that should be annotated to not be
allowed?

johannes