Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Sascha Hauer <s.hauer@pengutronix.de>
Cc:     Jakub Kicinski <kuba@kernel.org>, linux-wireless@vger.kernel.org,
        Neo Jou <neojou@gmail.com>,
        Hans Ulli Kroll <linux@ulli-kroll.de>,
        Ping-Ke Shih <pkshih@realtek.com>,
        Yan-Hsuan Chuang <tony0620emma@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        kernel@pengutronix.de, Johannes Berg <johannes@sipsolutions.net>,
        Alexander Hochbaum <alex@appudo.com>,
        Da Xue <da@libre.computer>, Po-Hao Huang <phhuang@realtek.com>,
        Viktor Petrenko <g0000ga@gmail.com>
Subject: Re: [PATCH v4 08/11] wifi: rtw88: Add rtw8821cu chipset support
References: <20221129100754.2753237-1-s.hauer@pengutronix.de>
        <20221129100754.2753237-9-s.hauer@pengutronix.de>
        <20221129081753.087b7a35@kernel.org>
        <20221202080952.GG9130@pengutronix.de>
Date:   Fri, 02 Dec 2022 14:36:41 +0200
In-Reply-To: <20221202080952.GG9130@pengutronix.de> (Sascha Hauer's message of
        "Fri, 2 Dec 2022 09:09:52 +0100")
Message-ID: <87359y3rty.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Sascha Hauer <s.hauer@pengutronix.de> writes:

> On Tue, Nov 29, 2022 at 08:17:53AM -0800, Jakub Kicinski wrote:
>> On Tue, 29 Nov 2022 11:07:51 +0100 Sascha Hauer wrote:
>> > +config RTW88_8821CU
>> > +	tristate "Realtek 8821CU USB wireless network adapter"
>> > +	depends on USB
>> > +	select RTW88_CORE
>> > +	select RTW88_USB
>> > +	select RTW88_8821C
>> > +	help
>> > +	  Select this option will enable support for 8821CU chipset
>> > +
>> > +	  802.11ac USB wireless network adapter
>> 
>> Those kconfig knobs add so little code, why not combine them all into
>> one? No point bothering the user with 4 different questions with amount
>> to almost nothing.
>
> I tend to agree here. I followed the pattern used with PCI support here,
> but I also think that we don't need to be able to select all chips
> individually. The following should be enough:
>
> config RTW88_PCI
> 	tristate
> 	depends on PCI
> 	default y
>
> config RTW88_USB
> 	tristate
> 	depends on USB
> 	default y
>
> Still I'd like to continue with the current pattern to not block merging
> of the USB support with this topic.
>
> I could create a follow up patch though if that's desired.

Yeah, a follow up patch is a good idea. Best to get USB support commited
first, after that we can discuss improvements.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches