Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ryder Lee <Ryder.Lee@mediatek.com>
To:     "keescook@chromium.org" <keescook@chromium.org>,
        =?utf-8?B?U2hheW5lIENoZW4gKOmZs+i7kuS4nik=?= 
        <Shayne.Chen@mediatek.com>
CC:     =?utf-8?B?U3RhbmxleVlQIFdhbmcgKOeOi+S+kemCpik=?= 
        <StanleyYP.Wang@mediatek.com>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?utf-8?B?SG93YXJkLVlIIEhzdSAo6Kix6IKy6LGqKQ==?= 
        <Howard-YH.Hsu@mediatek.com>,
        "gustavo@embeddedor.com" <gustavo@embeddedor.com>,
        =?utf-8?B?RXZlbHluIFRzYWkgKOiUoeePiumIuik=?= 
        <Evelyn.Tsai@mediatek.com>,
        =?utf-8?B?TW9uZXkgV2FuZyAo546L5L+h5a6JKQ==?= 
        <Money.Wang@mediatek.com>,
        "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>,
        "nbd@nbd.name" <nbd@nbd.name>,
        =?utf-8?B?TWVpQ2hpYSBDaGl1ICjpgrHnvo7lmIkp?= 
        <MeiChia.Chiu@mediatek.com>,
        "lorenzo@kernel.org" <lorenzo@kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        Sean Wang <Sean.Wang@mediatek.com>,
        "kvalo@kernel.org" <kvalo@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        =?utf-8?B?U3VqdWFuIENoZW4gKOmZiOe0oOWonyk=?= 
        <Sujuan.Chen@mediatek.com>,
        =?utf-8?B?Q2h1aS1oYW8gQ2hpdSAo6YKx5Z6C5rWpKQ==?= 
        <Chui-hao.Chiu@mediatek.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        =?utf-8?B?Qm8gSmlhbyAo54Sm5rOiKQ==?= <Bo.Jiao@mediatek.com>
Subject: Re: Coverity: mt7996_hw_queue_read(): Integer handling issues
Thread-Topic: Coverity: mt7996_hw_queue_read(): Integer handling issues
Thread-Index: AQHZBpsT2efY3IsmxECzUUgoRAK1m65blWsA
Date:   Sat, 3 Dec 2022 04:40:09 +0000
Message-ID: <786eff1a1751a5bc0dc68d6567be585b635bddb1.camel@mediatek.com>
References: <202212021411.A5E618D3@keescook>
In-Reply-To: <202212021411.A5E618D3@keescook>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Z2dLQk1aUW1scXUvaVk3bnB6TXhvcnQycHdtTDIvc1h3bFZrOTl2WFYwZE8y?=
 =?utf-8?B?MGFCaWxjeExpYXgveURzaGJKUDJNTTE4aG5FV2t2STRvcExrQ2w2ZjllZWww?=
 =?utf-8?B?OEZnRmJyNWo1V2lOV2hPYXd0bFBqMG14Q0ZtVURBRVVlNjBCdi9CbW5NZGhO?=
 =?utf-8?B?ZkREUldrZlljVThNeGhQNFZTRkpPTFlSNUdXUktpNEsyOWFGcFl5c2g5bXUy?=
 =?utf-8?B?akd5ZFN3OVBPUVNObHJESkNWaTBuNzZPTGx1K0kvbU02ZnFjS3cyRndpb0pN?=
 =?utf-8?B?UjlBZGdRSDNveGQvTWQvdDkrenRPNUdtL09qV28vcGl1ZXBoUW1NeVVxbUtH?=
 =?utf-8?B?RXRxdmxZd3pmTzBNMXI3c0owbjUzYW0zbms3Y3RseEREdUlhdTMweHRKMGUw?=
 =?utf-8?B?Y3ptbVdHU25TZFZ5UzZuU3hYOThtZ01HbGNGYUZUWm50UzUwSVRvUmkyVEgr?=
 =?utf-8?B?bGU3VUl4c3NGM1NmTWxscW5tY2xwQlBjbkVCamYybVpNeFlENEgwQ3A3NEdn?=
 =?utf-8?B?VU94UDE4ZlI3VjF0blU4Z2lKNDZBZWlZY2ViWWpaT3U2YVpiWHFhaSt1b21D?=
 =?utf-8?B?NHhYTk9sd0ExZ0dWaGtsYWt3bDlsbEE4SVk5blR2YnV1cU9telE0OE1DVWhM?=
 =?utf-8?B?aTJqeXZicXF3MGdYNDh2T0xhakF4bzhkRnErUTZLTTVZWW5qZVJMUXZkeUl3?=
 =?utf-8?B?N2N3NjVJRGt1NS9vMTlXVFFzdWdoemwrM2F1TUZSMFZsM2VKdVJQa05Ubk5I?=
 =?utf-8?B?TWtxMzlRQWZXUlZJeU45bWNENWJpZ1BoVDJ1ZldTd29uNzE1SHB6NFoyNURT?=
 =?utf-8?B?NUlCNzRhTjVxVzZOci9lRVgvVWlHdHBDbloyaHZTS3JwRWIzVjUrQis2aHJR?=
 =?utf-8?B?eGNvd212Y0RZY1dkZllDdks5QnFvWE8zR0Fidkw4V01HOW1xTlFlWmpRdUFT?=
 =?utf-8?B?OVl0K2RFUnZaaWNFT0U2ZFNHeW0veUZRWlFHYkg5TkF5aU1Ld0ZnRU50VXZV?=
 =?utf-8?B?NSt2dGxmL3J5eXkrQlhQenYyN2VVYTJJUFkxV05Za3lid2RZc2kreDQ0NXpa?=
 =?utf-8?B?QVh2djBBRzA2bERvNk1WSWFkODNnZlF5ZUFidWRDdUkwM3ZsYThGcVdtTzBX?=
 =?utf-8?B?aWRPWkhucWwvNGp5cUNXTHdOb3ViUkpKUlZTZVYxcGl4TDcyaThPWGtoYXdU?=
 =?utf-8?B?bUFjSkMwK0xWL0VHbkVYWUpqNWxaVks5UFlWcEJRWWw1dGcrcXpnUHdZWm9a?=
 =?utf-8?B?NkhmWG55VE5JYnRUYTFZUng1dTUxTEgwUWNQTnByb2xXa1gyQUNzU0UyTWZU?=
 =?utf-8?B?SnZ6dC9TVmc5eTFERXhqajlweEtDQ0VJT1J1SE9kQ09zYSt4dklsREJlZGk2?=
 =?utf-8?B?T2g4aGRGZmJuR1prZlpLK0owc0ErYkRoc0c4d0xzZWZic3lMZDRTaWJIdW9B?=
 =?utf-8?B?MUhYTC9OR1crM3R6b0VlTDhrREwyUFFsbnVLQmRUVHkwVElhYkZrWkkrc3RT?=
 =?utf-8?B?aWQvNU1VSEdkenNnMU00VCtwZzVLMWxVNnhUVEtkUGZ2QVE5TG0zeW93NFRn?=
 =?utf-8?B?ODNSWHl4cTJxYW9VVnpuMi9hZVAybVhkeHRTRGx0ZGtWWVJEazN2a2thY2Zi?=
 =?utf-8?B?amxlS1ZvZGtoN0NaNmpSUmJ0c2RGRklTeUNYYmZLZnVpWVllVFdCRGJKU0hK?=
 =?utf-8?B?T05LQTJLbjNINy9QaFBDWjc0bWdMZWpLSWw4RzcxZTNiS2NGOXdnTzBwSGFZ?=
 =?utf-8?B?ZEgwMDUvdlU1WlhSUUNxT21xaHMzUkFzK3RnRmt2TTVVZ2dtbW5lRkRRSVRV?=
 =?utf-8?B?akFaUzJwY2FXNGEvRkNjcWJyS2xzdXNjMlpQVnNZVlJSUzNuTHFiYmk2VVk5?=
 =?utf-8?B?MGhreStyd3EycVNxTnhPdXlDbzFES1J5Zm83M25pcFpaanhXOWZRNkIrVGhs?=
 =?utf-8?B?Z2syYzBDbDJYR3VnMkQrTGgyYk9sbUx0Nm1iT3lpVUFySjY0WExUckR5QTVs?=
 =?utf-8?B?U1RPdE9yUVVkNFB3dWtKWTFyOS9abTZPWTVRQWNIbzg1TnNVUkJjdkh3SktR?=
 =?utf-8?B?b2Y5M2oyWnd6Y2dIVlJKamZNaHZabytoV3hIV2RYTWlENDZ5WGY2VWorY0pF?=
 =?utf-8?B?Vzh0bFc5YnJlOVJ5T0xrb3d0cHhhWm5TSzk0S2dyQ3lGMVgyRXlxNnR4NHhw?=
 =?utf-8?B?Vnc9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <48C42208EE1D874895BF59C22D9BBA96@apcprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY0PR03MB6354.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 330158ed-c5de-4661-ba8e-08dad4e87553
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2022 04:40:09.2112
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Lz9wUtsiNuRHDU7/DxvOnuIo5HMY+i4xLbqF9wqE4wFsjuDP4fQElja5IQLUWuxaTy1YoK3yidVkLuAuTK4l3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR03MB5254
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

T24gRnJpLCAyMDIyLTEyLTAyIGF0IDE0OjExIC0wODAwLCBjb3Zlcml0eS1ib3Qgd3JvdGU6DQo+
IEhlbGxvIQ0KPiANCj4gVGhpcyBpcyBhbiBleHBlcmltZW50YWwgc2VtaS1hdXRvbWF0ZWQgcmVw
b3J0IGFib3V0IGlzc3VlcyBkZXRlY3RlZA0KPiBieQ0KPiBDb3Zlcml0eSBmcm9tIGEgc2NhbiBv
ZiBuZXh0LTIwMjIxMjAyIGFzIHBhcnQgb2YgdGhlIGxpbnV4LW5leHQgc2Nhbg0KPiBwcm9qZWN0
Og0KPiANCmh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL3NjYW4uY292ZXJpdHku
Y29tL3Byb2plY3RzL2xpbnV4LW5leHQtd2Vla2x5LXNjYW5fXzshIUNUUk5LQTl3TWcwQVJidyFq
Qk9vajZMTXFxQThFMEF5aktRVGEtMHJWemNGaVozQmJwY2lFSW43c285NzRrY01CZUc0elptLVFV
NEF1ZExYWTctak5VU3QwdW56QXQyemlyU0YkwqANCj4gIA0KPiANCj4gWW91J3JlIGdldHRpbmcg
dGhpcyBlbWFpbCBiZWNhdXNlIHlvdSB3ZXJlIGFzc29jaWF0ZWQgd2l0aCB0aGUNCj4gaWRlbnRp
ZmllZA0KPiBsaW5lcyBvZiBjb2RlIChub3RlZCBiZWxvdykgdGhhdCB3ZXJlIHRvdWNoZWQgYnkg
Y29tbWl0czoNCj4gDQo+ICAgVGh1IERlYyAxIDE3OjI5OjE0IDIwMjIgKzAxMDANCj4gICAgIDk4
Njg2Y2QyMTYyNCAoIndpZmk6IG10NzY6IG10Nzk5NjogYWRkIGRyaXZlciBmb3IgTWVkaWFUZWsg
V2ktRmkNCj4gNyAoODAyLjExYmUpIGRldmljZXMiKQ0KPiANCj4gQ292ZXJpdHkgcmVwb3J0ZWQg
dGhlIGZvbGxvd2luZzoNCj4gDQo+ICoqKiBDSUQgMTUyNzgxMzogIEludGVnZXIgaGFuZGxpbmcg
aXNzdWVzICAoU0lHTl9FWFRFTlNJT04pDQo+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL21lZGlhdGVr
L210NzYvbXQ3OTk2L2RlYnVnZnMuYzo0NjAgaW4NCj4gbXQ3OTk2X2h3X3F1ZXVlX3JlYWQoKQ0K
PiA0NTQgICAgIAlmb3IgKGkgPSAwOyBpIDwgc2l6ZTsgaSsrKSB7DQo+IDQ1NSAgICAgCQl1MzIg
Y3RybCwgaGVhZCwgdGFpbCwgcXVldWVkOw0KPiA0NTYNCj4gNDU3ICAgICAJCWlmICh2YWwgJiBC
SVQobWFwW2ldLmluZGV4KSkNCj4gNDU4ICAgICAJCQljb250aW51ZTsNCj4gNDU5DQo+IHZ2diAg
ICAgQ0lEIDE1Mjc4MTM6ICBJbnRlZ2VyIGhhbmRsaW5nIGlzc3VlcyAgKFNJR05fRVhURU5TSU9O
KQ0KPiB2dnYgICAgIFN1c3BpY2lvdXMgaW1wbGljaXQgc2lnbiBleHRlbnNpb246ICJtYXBbaV0u
cWlkIiB3aXRoIHR5cGUNCj4gInU4IiAoOCBiaXRzLCB1bnNpZ25lZCkgaXMgcHJvbW90ZWQgaW4g
Im1hcFtpXS5xaWQgPDwgMjQiIHRvIHR5cGUNCj4gImludCIgKDMyIGJpdHMsIHNpZ25lZCksIHRo
ZW4gc2lnbi1leHRlbmRlZCB0byB0eXBlICJ1bnNpZ25lZCBsb25nIg0KPiAoNjQgYml0cywgdW5z
aWduZWQpLiAgSWYgIm1hcFtpXS5xaWQgPDwgMjQiIGlzIGdyZWF0ZXIgdGhhbg0KPiAweDdGRkZG
RkZGLCB0aGUgdXBwZXIgYml0cyBvZiB0aGUgcmVzdWx0IHdpbGwgYWxsIGJlIDEuDQo+IDQ2MCAg
ICAgCQljdHJsID0gQklUKDMxKSB8IChtYXBbaV0ucGlkIDw8IDEwKSB8DQo+IChtYXBbaV0ucWlk
IDw8IDI0KTsNCg0KdTMyIGN0cmwgPSBCSVQoMzEpIHwgKG1hcFtpXS5waWQgPDwgMTApIHwgKG1h
cFtpXS5xaWQgPDwgMjQpOw0KDQpIbW0gLi4ud2hlcmUncyB0eXBlICJpbnQiICgzMiBiaXRzLCBz
aWduZWQpIGZyb20/DQoNClJ5ZGVyDQo+IDQ2MSAgICAgCQltdDc2X3dyKGRldiwgTVRfRkxfUTBf
Q1RSTCwgY3RybCk7DQo+IDQ2Mg0KPiA0NjMgICAgIAkJaGVhZCA9IG10NzZfZ2V0X2ZpZWxkKGRl
diwgTVRfRkxfUTJfQ1RSTCwNCj4gNDY0ICAgICAJCQkJICAgICAgR0VOTUFTSygxMSwgMCkpOw0K
PiA0NjUgICAgIAkJdGFpbCA9IG10NzZfZ2V0X2ZpZWxkKGRldiwgTVRfRkxfUTJfQ1RSTCwNCg==