Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Sat, 03 Dec 2022 07:37:17 -0800
From:   Angus Ainslie <angus@akkea.ca>
To:     Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc:     Andy Green <andy@warmcat.com>, Shengyu Qu <wiagn233@outlook.com>,
        franky.lin@broadcom.com, linux-wireless@vger.kernel.org
Subject: Re: AP6275 / bcm43752 pcie on mainline brcmf
In-Reply-To: <184d89525a0.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
References: <TY3P286MB26114DD461F50814980453E598029@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
 <08416710-655a-c87c-a599-3fe2563f7de4@warmcat.com>
 <18470a1e910.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
 <TY3P286MB26115A58795F264893CCB40198029@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
 <184720fc920.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
 <TY3P286MB26118BD94839F752CADCCF5298079@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
 <625f1d5d-e137-7ad7-96b9-92035e87df8b@broadcom.com>
 <638afa8e-a393-410c-3182-0d8e9b6da17d@warmcat.com>
 <7bf5884906b1abc30adebd3c915a3259@akkea.ca>
 <18486ca8490.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
 <a25fbe81f6f5615a2cfb7fda80d6db9b@akkea.ca>
 <3163e341-bcfc-a2c3-f0e1-5b62c9da2f43@broadcom.com>
 <852dcabac6bd70a7d55b5ea3f6b0df20@akkea.ca>
 <184d89525a0.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>
Message-ID: <c33d42d546aa6755acc00b8b2e3a4b36@akkea.ca>
User-Agent: Roundcube Webmail/1.3.17
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022-12-03 07:22, Arend Van Spriel wrote:
> On December 3, 2022 2:56:39 PM Angus Ainslie <angus@akkea.ca> wrote:
> 
>> On 2022-11-29 11:48, Arend van Spriel wrote:
>>> On 11/17/2022 7:36 PM, Angus Ainslie wrote:
>>>> On 2022-11-17 10:12, Arend Van Spriel wrote:
>>>>> On November 17, 2022 5:06:25 PM Angus Ainslie <angus@akkea.ca> 
>>>>> wrote:
>>>>> 
>>>>>> On 2022-11-17 04:01, Andy Green wrote:
>>>>>>> On 11/17/22 09:23, Arend van Spriel wrote:
>>>>>>>> On 11/16/2022 1:25 PM, Shengyu Qu wrote:
>>>>>>>>> Got a new version of downstream driver and firmware here:
>>>>>>>>> https://gitlab.com/rk3588_linux/linux/external/rkwifibt/-/tree/linux-5.10-gen-rkr3.4
>>>>>>>> 
>>>>>>>> Thanks for that. The firmware indeed seems to originate from
>>>>>>>> Synaptics
>>>>>>>> and this module can be found on wifi-alliance product finder:
>>>>>>>> 
>>>>>>>> https://www.wi-fi.org/product-finder-results?sort_by=certified&sort_order=desc&keywords=ap6275
>>>>>>>> 
>>>>>>>> We have no known contacts there and they do not seem to have 
>>>>>>>> much
>>>>>>>> interest in open-source. In that gitlab repo I see they are
>>>>>>>> providing
>>>>>>>> bcmdhd driver and I assume they consider that sufficient.
>>>>>>>> 
>>>>>>>> Will see what I can do. First have to think on how to approach
>>>>>>>> this
>>>>>>>> failure to get most out of a debug effort. I do not have the
>>>>>>>> module
>>>>>>>> over here so we would need to go back and forth. The fact that 
>>>>>>>> the
>>>>>>>> issue is seen on both SDIO and PCIe is somewhat encouraging.
>>>>>>> 
>>>>>>> Yes it seems that at some point with some firmware, SDIO has 
>>>>>>> worked
>>>>>>> for, eg, Angus.  And, it should work well with bchdhd (but that
>>>>>>> does
>>>>>>> not seem to work for scan for me on v6.1-rc5 uplevel with the
>>>>>>> firmware
>>>>>>> load changed to use kernel apis; but the firmware has no timeout 
>>>>>>> on
>>>>>>> bcmdhd). So it doesn't feel a million miles away.
>>>>>> 
>>>>>> This is the firmware we have been using for SDIO. It was sent to 
>>>>>> us
>>>>>> directly by SparkLAN so not sure how it compares to other 
>>>>>> variants.
>>>>>> 
>>>>>> https://source.puri.sm/Librem5/firmware-brcm43752-nonfree/-/tree/master/firmware/brcm
>>>>> 
>>>>> It is a tad bit older:
>>>>> 
>>>>> $ strings brcmfmac43752-sdio.bin | grep FW-TAG
>>>>> <FW-TAG>4362a2-roml/config_sdio_ampak_release_he
>>>>> Version=18.35.387.23.7 (b328500@shgit) (wlan=r880297)
>>>>> Date=2020-07-13T10:34:00Z FWID=01-f50fdff0
>>>> 
>>>> Currently it's broken for hotspot mode but I haven't had the chance 
>>>> to
>>>> see if that is FW or something further up the stack.
>>> 
>>> Hi Angus,
>>> 
>>> When you added support for this device in brcmfmac you marked it as a
>>> Cypress device. Are you sure about that? AFAICT this device is coming
>>> from Synaptics.
>> 
>> Hi Arend,
>> 
>> I assumed Cypress based on the fact that it most closely resembled the
>> 4373 from the driver side.
> 
> Right. Both are based on the same chip architecture that they brought
> from Broadcom so the similarities are not surprising.
> 
>> How would I figure out whether it's Cypress or Synaptics ?
>> 
>> When I search the web for it I only find SparkLAN or "AMPAK 
>> technology"
>> references.
> 
> Earlier my colleague Franky found this link to WFA certificate:
> 
> https://api.cert.wi-fi.org/api/certificate/download/public?variantId=103641
> 
> WFA and FCC are usually good sources of info. Also the product pages
> of the vendors are worth checking. I have them bookmarked out of
> professional interest ;-)
> 

I did find FCC references but those seemed ambiguous as well. Thanks for 
the wi-fi.org link.

Should I send a patch renaming SDIO_DEVICE_ID_BROADCOM_CYPRESS_43752 -> 
SDIO_DEVICE_ID_BROADCOM_43752 ?

Thanks
Angus

> Regards,
> Arend