Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5575477rwb; Mon, 5 Dec 2022 00:40:46 -0800 (PST) X-Google-Smtp-Source: AA0mqf6UG+t4kbpTUMdL2hY8TMnWPjNmsG1Yg8vFG7Mf5t58kgYyU/i2T5z3ZLh5SnZZH1mXpx5w X-Received: by 2002:a17:907:2387:b0:7c0:d6b2:1fd4 with SMTP id vf7-20020a170907238700b007c0d6b21fd4mr7901062ejb.703.1670229646726; Mon, 05 Dec 2022 00:40:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670229646; cv=none; d=google.com; s=arc-20160816; b=OWzs/V3gajh1Isg/5N4keQQsods9g2EqkKdePyXmpaoYPaeb190ItuptILa/zpYq5d 7g30Oq0dB2iLzoWDqtgBUtoh8Z2IGqb1h3F6UjYInqcJeSIzyY4r+x8FyY/eWC8/TAyR f4lD1RaFNXPmwgjhe+OcytbiVzgKqNot/j8DeBwZ2F06Obijeb6WRiZxY9Eo2+xQs/1X +lFwVRAtB9FI8x4lZH3rpgOcWgl4hzm/taA7EzauA2C4lflwRCEMhQjLbzjIXmUvUjCH 6GsX/lwj/BXdHxkp9592PXlKYzzJvn5h9CtT+zsfPFhGriJqnj/uNzEB7s+sAKv7U6x+ 16QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wv5xmwbXzLCB34HfBfe00QlHLf5Ga/3sd3K2EHEEfRg=; b=u3LjqT1rxjcT1X6xaulo/hso7Megw+2EgOL8UvQNi3Yv8lf7AVhE51JHi7yoXKY0jC sAt9uAorqeB87Dp1SYaIUajw3E7lyM3jYPwaB2jzOLFN5cqQhVusoTzQVXR2yIV9iLo5 Otm7SFUhYfnMbrjwm9N5kvn3u+/qfHe6hKHf4WF9q+RLDqdx+Y7jmo84lZBNzNzkuF2g 9VOuGkhOT1JN94YywvFXOseYqp5m02XpazFv3ivl/FNLzJG5cXgc+yJY3nzxXSw8Tj5k C1oPfaJI6VSA0S44QwlrjlAaUEo8usIzrTSNoLXyzksU8PQhj3L/hdX6tBlLBHCS/vtK RY6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GWD0CWEv; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t4-20020a056402240400b0046c0137c466si8487116eda.293.2022.12.05.00.40.30; Mon, 05 Dec 2022 00:40:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GWD0CWEv; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232158AbiLEIgu (ORCPT + 66 others); Mon, 5 Dec 2022 03:36:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232138AbiLEIgi (ORCPT ); Mon, 5 Dec 2022 03:36:38 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9806167E9 for ; Mon, 5 Dec 2022 00:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670229397; x=1701765397; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YGKVIzE59FVad3tp7Qsn6Yt/SmItQT3t7bKakcovB98=; b=GWD0CWEvJqK7A8du5BavZ4KfEnY+tMFV4LyNRZAtlXmB8GrAWKAfFAbI JW9GFL3JzS7E2sE0ckSUkexmDZEMLzwO1VPcWEVvDZ8KmRxevCmQb8FEX msoHAgWsFxMRpYAqJcRPY31VQy3QI8ngs5pkKWG/133mIKzfRNeo1Voew ogOpHSbenGvbAmK6o9fZAxt8pZUFNFSERof4G3e5aku5j5y3N6SHXfJqR YjQZ05tzc+s2UuWfi40Z7fdWK4Z8TllPlZDY9ZoIS5w4zReXBjiwwYnWf uzMZG1KPTqwUsDKCwgjktO9TOzLVIjwTSNq9kHMGT+KgvRfd4Y0lHmd/h Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="316323182" X-IronPort-AV: E=Sophos;i="5.96,218,1665471600"; d="scan'208";a="316323182" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 00:36:36 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="752100443" X-IronPort-AV: E=Sophos;i="5.96,218,1665471600"; d="scan'208";a="752100443" Received: from eamit-mobl1.ger.corp.intel.com (HELO ggreenma-mobl2.lan) ([10.251.181.23]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 00:36:34 -0800 From: gregory.greenman@intel.com To: kvalo@kernel.org, johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Naftali Goldstein , Gregory Greenman Subject: [PATCH 09/11] wifi: iwlwifi: mvm: d3: add TKIP to the GTK iterator Date: Mon, 5 Dec 2022 10:35:46 +0200 Message-Id: <20221205102808.746f40250502.Ieef45ffc617726cb47b3a4ec625d513d16082f4b@changeid> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20221205083548.236620-1-gregory.greenman@intel.com> References: <20221205083548.236620-1-gregory.greenman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Naftali Goldstein This was missed when this function was refactored out of iwl_mvm_wowlan_program_keys. Signed-off-by: Naftali Goldstein Signed-off-by: Gregory Greenman --- drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c index 919b1f478b4c..c5ad34b063df 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c @@ -599,6 +599,11 @@ static void iwl_mvm_wowlan_gtk_type_iter(struct ieee80211_hw *hw, switch (key->cipher) { default: return; + case WLAN_CIPHER_SUITE_TKIP: + if (!sta) + data->kek_kck_cmd->gtk_cipher = + cpu_to_le32(STA_KEY_FLG_TKIP); + return; case WLAN_CIPHER_SUITE_BIP_GMAC_256: case WLAN_CIPHER_SUITE_BIP_GMAC_128: data->kek_kck_cmd->igtk_cipher = cpu_to_le32(STA_KEY_FLG_GCMP); @@ -610,13 +615,13 @@ static void iwl_mvm_wowlan_gtk_type_iter(struct ieee80211_hw *hw, if (!sta) data->kek_kck_cmd->gtk_cipher = cpu_to_le32(STA_KEY_FLG_CCM); - break; + return; case WLAN_CIPHER_SUITE_GCMP: case WLAN_CIPHER_SUITE_GCMP_256: if (!sta) data->kek_kck_cmd->gtk_cipher = cpu_to_le32(STA_KEY_FLG_GCMP); - break; + return; } } -- 2.35.3