Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ac0506a5-fa37-3fe4-8051-e1febd58d538@quicinc.com>
Date:   Mon, 5 Dec 2022 11:40:28 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH v2 01/10] mac80211: generate EMA beacons in AP mode
To:     Jouni Malinen <j@w1.fi>, Johannes Berg <johannes@sipsolutions.net>
CC:     <linux-wireless@vger.kernel.org>
References: <20221114201912.22893-1-quic_alokad@quicinc.com>
 <20221114201912.22893-2-quic_alokad@quicinc.com>
 <20221202164439.GA700414@w1.fi>
Content-Language: en-US
From:   Aloka Dixit <quic_alokad@quicinc.com>
In-Reply-To: <20221202164439.GA700414@w1.fi>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/2/2022 8:44 AM, Jouni Malinen wrote:
> On Mon, Nov 14, 2022 at 12:19:03PM -0800, Aloka Dixit wrote:
>> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
>> @@ -3338,7 +3338,8 @@ cfg80211_beacon_dup(struct cfg80211_beacon_data *beacon)
>>   	len = beacon->head_len + beacon->tail_len + beacon->beacon_ies_len +
>>   	      beacon->proberesp_ies_len + beacon->assocresp_ies_len +
>>   	      beacon->probe_resp_len + beacon->lci_len + beacon->civicloc_len +
>> -	      ieee80211_get_mbssid_beacon_len(beacon->mbssid_ies);
>> +	      ieee80211_get_mbssid_beacon_len(beacon->mbssid_ies,
>> +					      beacon->mbssid_ies->cnt);
> 
> beacon->mbssid_ies can be NULL here and that is going to result in a
> kernel panic. For example, check with hostap.git test case
> ap_ht_20_to_40_csa.
> 

Oh, thank you, will fix it.

@Johannes, I noticed that commit 2b3171c6fe0af24b5506
missed freeing old->mbssid_ies (2 places) and old_beacon->mbssid_ies 
that were part of 
https://patchwork.kernel.org/project/linux-wireless/patch/20210916025437.29138-4-alokad@codeaurora.org/.
I will add those in the next version as well.
Any better way to catch missing free() calls that you can recommend?

Thanks.