Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7444965rwb; Tue, 6 Dec 2022 06:01:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf4E6BDIzHQ2yexRibTFmpEFyMUWUrqnrw6/BHcPd9T8z1Z16hsYAsbg8d09JqOILIxQ4A6o X-Received: by 2002:a17:907:d68b:b0:7b9:dff1:b26e with SMTP id wf11-20020a170907d68b00b007b9dff1b26emr16777743ejc.289.1670335273396; Tue, 06 Dec 2022 06:01:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670335273; cv=none; d=google.com; s=arc-20160816; b=HwOOaUyUpJP96U77bqjfFxmroCvyDH3Hv7khwwND6U75+dqSg66afmgzkAHY/lmYPQ eFmLuWA+D5S+2RiPVAPqJqZjJa1Yo0UWPsGYhVNsRPoMzIgF3DkV48j1I9s7/fJgvxr/ 6xvAQlkC/RL+I6w5m1pmupzMznOP+FJgckmknYaOb/4bDJyPPW1soDuLCZ0TMRq/vq+w jmDnyOWJBMN2jdFCUePLJcASY+OEtMcUecHXwxl57hvCSWNCKCNvAP8KUtlWuJ6f0BlL gtyVyiQ63zLEWowqAR5nGPxzpWv3gabLj1C0xtAEMkkdPCPjlCxcEshM/NTqJTJYyzO7 O4fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Soun4tT+fy6mVn1zaityySCqNSstbwmfPbovyOA+1DM=; b=hOLfZVMxb7okkXnt3LIuVsp7GcmJq8APPoffNqh8VLkgjRLn6J6WBxFf75f8jlXwpT ajTlGkmW/ZXa6QmC7n+t/qqrqpHTyiWdzUqMLIIDPVYmUDWjzo1/G5Ebpja0gDZaAR7+ EueSpdav35xzvTqz+Bm6aC1tE9b1Hqvo4cX0YWRIieYVpKJrogH2gCT7utrGqZd99t+V VzBUBjka9OZmW8KxPwciHO2TaJy2AI+ynFquZCMCamm0koKKw0dQUEOPe3wydessDDkO VExoVL2Zzi1kc8gsHTFOjL3oK9OdWi5h96EOr8RsyU5lpd9+2o+emWdRN6n2DB8N4n/o Myzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp30-20020a1709073e1e00b007c0f057e271si5356513ejc.853.2022.12.06.06.00.51; Tue, 06 Dec 2022 06:01:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234261AbiLFNwf (ORCPT + 66 others); Tue, 6 Dec 2022 08:52:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234422AbiLFNwd (ORCPT ); Tue, 6 Dec 2022 08:52:33 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E91682BB1F for ; Tue, 6 Dec 2022 05:52:28 -0800 (PST) Received: from dggpemm500007.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NRMK52xcVzRpZc; Tue, 6 Dec 2022 21:51:37 +0800 (CST) Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 6 Dec 2022 21:52:26 +0800 From: Yang Yingliang To: , CC: Subject: [PATCH] wl3501_cs: don't call kfree_skb() under spin_lock_irqsave() Date: Tue, 6 Dec 2022 21:50:14 +0800 Message-ID: <20221206135014.2208894-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under spin_lock_irqsave(). Signed-off-by: Yang Yingliang --- drivers/net/wireless/wl3501_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/wl3501_cs.c b/drivers/net/wireless/wl3501_cs.c index 1b532e00a56f..7fb2f9513476 100644 --- a/drivers/net/wireless/wl3501_cs.c +++ b/drivers/net/wireless/wl3501_cs.c @@ -1328,7 +1328,7 @@ static netdev_tx_t wl3501_hard_start_xmit(struct sk_buff *skb, } else { ++dev->stats.tx_packets; dev->stats.tx_bytes += skb->len; - kfree_skb(skb); + dev_kfree_skb_irq(skb); if (this->tx_buffer_cnt < 2) netif_stop_queue(dev); -- 2.25.1