Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp691878rwb; Wed, 7 Dec 2022 04:01:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf5oGl7JgA0aIryLk7dFBaN+UGf8kf8mQh40LtzjawDk0lXRmlUXqp/uNGz7Nfcgo6UJaMRb X-Received: by 2002:a17:907:9253:b0:7c0:e984:e74e with SMTP id kb19-20020a170907925300b007c0e984e74emr12217791ejb.238.1670414473136; Wed, 07 Dec 2022 04:01:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670414473; cv=none; d=google.com; s=arc-20160816; b=hBjZVFt4874W6AOMqVZZl793K9Avs0y0CAV06OMhC5OmVFGUMix+kpPyx1O18sETxZ b1f+3ol6n1WIDEtVmj0hRfzfsElFo8VHUD5tQHDoFcFBs/3q/zE0d510PkF8qcQGeawT XH3RzX9UPXa87HGkodyLudSvat2Z5hZGtsulTFzxdaxgXw1zGWp2A52jjHj8Vh/3a4It v8vHumg6aVYaxwFRu4GHjhe8AzcW8ei9iNxxYoCy+/8OvKBAgV0rCjlnKyiOo4hW3qld KtEgqSXV4IqLQcOO0hE0d5wtYDRRBUAT5ABAUlmjrGsmPXplj1Hmd9xwq6lEt1lr2a5f Lj+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=lDbTmmdpNlyHEA4UACPm+GuCrxJc11Z9bSZoLZxBGjs=; b=K6jI6iGe5VMHWzBdEQBqRXZiL+hHCKfam6oQoMPjpBp/iJGjF3PWdUodkP5oPgCcFR kVNRW/ZGmAc9g4LJogLy/gIAAEx+6HYkzvBOtXOw0hXbwVBNtnWXsgSFn1bb6K7yJ83w haVUjQPd9q1B9e9dvlXza6VRLZwOvT05/Nty/PpbzM8JvlnrN0KlGh3g0Y9/bA4vcrzZ 6vGU+Z2jEWT8B/PjAkWPj/fboCc4Lxu7YwyAcAF2xS2t/qnzwfjFuZAKOEhWjpQ5RfP+ PmCfQ1fybKF2oneVtvOzvF6BWlLL4ofQbV5aiQ9UtPZSe1WziHXQ4zx5m9PB41KTlEIu 6tBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HEWbuwJV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w3-20020a056402128300b0046acab646ecsi3691736edv.81.2022.12.07.04.00.50; Wed, 07 Dec 2022 04:01:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HEWbuwJV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229758AbiLGLyq (ORCPT + 66 others); Wed, 7 Dec 2022 06:54:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbiLGLya (ORCPT ); Wed, 7 Dec 2022 06:54:30 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C06E853EC7 for ; Wed, 7 Dec 2022 03:53:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 47F7860FE9 for ; Wed, 7 Dec 2022 11:53:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6C88C433D7; Wed, 7 Dec 2022 11:53:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670414005; bh=U+9ldIYftCfe1hNasUsm/uCtDZz4afQPBzeuWDbHM8I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HEWbuwJVcNmg6ylv+bF7VpRZB/nw9bCmP6tHqfiTgWN6MLYdcPZTWGwiNlTf0agO2 Km5yGO2dvyEd/XTkeknL8LhikPdQZX1H36bs8nusupJgJ4EXtGhtqzVk0f+8vuz1oa iL0kmirFwUs5eX2ydBNbvV8JdM0zIMVnyYZDfy6mcksOcABWRs//yQSHgsse5w0sqh gp9ot8OrA6xY0bdLsRJjJEYo1f1O7joQVizWVlEVsy0pUkFTs4A97HmzvR1/H1b7ab bTJGYSPgQjOk63TsedQG6yfjLphXoeu9K6gzyAwvZYq9+QiWmqiMcr7t8rnn/iWUWR gYO9oqWKMwBzQ== From: Kalle Valo To: Yang Yingliang Cc: , Subject: Re: [PATCH v2 0/3] wifi: rtlwifi: don't call kfree_skb() under spin_lock_irqsave() References: <20221207062823.3474551-1-yangyingliang@huawei.com> Date: Wed, 07 Dec 2022 13:53:21 +0200 In-Reply-To: <20221207062823.3474551-1-yangyingliang@huawei.com> (Yang Yingliang's message of "Wed, 7 Dec 2022 14:28:20 +0800") Message-ID: <87sfhrmnv2.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Yang Yingliang writes: > It is not allowed to call kfree_skb() from hardware interrupt > context or with interrupts being disabled. This patchset is > trying to add all skb to a free list, then free them after > spin_unlock_irqrestore() at once. > > v1 -> v2: > change subject prefix to "wifi: rtlwifi: ..." I guess these are just compile tested? Please always include that information to the commit log. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches