Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp926406rwb; Thu, 8 Dec 2022 04:53:59 -0800 (PST) X-Google-Smtp-Source: AA0mqf7mlkHy1lmR1hzFgFREZ4iPNdDQ3aA5/8UUYG9X4Bprw4+sfTbAEf28KpxXklq75C7rKTkc X-Received: by 2002:a17:906:d84:b0:7c0:b6e2:a1c8 with SMTP id m4-20020a1709060d8400b007c0b6e2a1c8mr23557072eji.398.1670504039399; Thu, 08 Dec 2022 04:53:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670504039; cv=none; d=google.com; s=arc-20160816; b=0p8rx5wRnnB+wDr5fLEC//pHh3IlJ+nW3YBWSovrtYeDfo8xnmbxwQfvBJbpGIH5hb 8xSif1QERo5+001SaAkhiM1/0W1ClHanP9vfEjlsDgBjlxXzrnvsY5xP4GdtQVwCAaxg HWUccxTTdbkm4MzDYBfTl9V3zh8JeH8T8LHow1aQA+2GbkszFA7EKNbb+M9UEdA69ICd W0c9v1WChr1x5P029znOfQr3wspuxbDiJEPlclerEcotYm6H1Q9AgMSNgEN1H2RgzbUv fH+RXNhn55AIJ+YetlQJzWVu4JCi7IbpZUZHGSukq2bkNVKrJ0vz4U2BA40PohCsxud9 o6gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=I0JHokktbhkIah68yRfG4/HegSUlSxkKPY0X0eASPTw=; b=dddK8ke7x5x3IeWxE4WbSen6V0hR/pJLr8stiGJS1CAV2oD1esfBreK4qlDah6WIVh 3OkEJ1Bd7kINBoIttkXDBTrS9MTnnxdlJ5ptdQ4fPbnJXuWY5e837TaUkaYx1vpBTvrE h8SjOgvg1Aqgk+ZRWpje6A9VigjdKlbxuuD7wfpyLjc6PWXWamPkyPk9MEqxbGj0NI+2 VsROxnYN/v/r5C3F2pHXOQwYQQbmFxI6b3jfOHoxFSZUUH5xvpgqxlAyRdl8IbsZ3YzI G2cLTZjbzv7do4JbhJImdnhXKzoCXy6N1mK0za2GnSWBTu2uI/Ll/nOVSg4Qw/lskAnr dM0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=ty9E24a8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b12-20020a056402350c00b0046400f454a3si7391923edd.125.2022.12.08.04.53.42; Thu, 08 Dec 2022 04:53:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=ty9E24a8; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbiLHMw3 (ORCPT + 65 others); Thu, 8 Dec 2022 07:52:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbiLHMwZ (ORCPT ); Thu, 8 Dec 2022 07:52:25 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB8668C458 for ; Thu, 8 Dec 2022 04:52:24 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id vv4so3625565ejc.2 for ; Thu, 08 Dec 2022 04:52:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I0JHokktbhkIah68yRfG4/HegSUlSxkKPY0X0eASPTw=; b=ty9E24a8Msd/UVFqtd/bV1EDblMKDBTEmNvE/wTbeFhCjk8chekOlzT2DnFZv17WYY 497Pt6JBvMGuuYgJ8x1xtWWAczj0K6gZrwlpafh7f6nD9Z9qujy5ixCjyLTDWgAWdX8a xmHOAPheITLnBvP7sNLMsMo0DY60P/dXds7naRx5d5E4vMtzSlw9jJWx+yq4pHnp+M2w 5pjm0hurzj55X1zpJDva8mdu05RZgyFx0VpKHy6TINR+YZ0nN9dmhP4bt6nbW7Ddyyu4 LzJieuxdTYHf3vBaLkG1l2uTd9zKcF82p5egg8HQuOT0B0uEZU0Sr/hWkkElO8V8x9+G Abjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I0JHokktbhkIah68yRfG4/HegSUlSxkKPY0X0eASPTw=; b=xYMQSfVB2fLYDxqaY85MwmvYhlBietnQ5HLIospgcRWezEAbkW3fb3p6iTFz65SQVB QTcsTQ7ECRsgt6rsivppyn1esYbBenaYB+lR18jIlpGje8B0mcAuBibuf0nbGSKQxjC+ mv0jhberknqtbTlp3DWtnNngUsPUs0ajzep498kM1ahKLHR+IPjJ9VAWAnFKtlv1VLhb hhTR8Y+i2S+CtPZ6hzDKtcwe69Bo1SAjJ9FpAbBGXktQQjOYv/kuNssfeeRbG4SIkt82 nZK4XrbvgxwXOZvr9RCFC2gzN0V24kMWb4vh0Jbrken+CC3Ga4cFbl71rxVdi7Tkth/o /jyg== X-Gm-Message-State: ANoB5plmN86HGFr+WYog7YK8gh9OEiU7sqjGcCTt3yS4d1sq4mGCmspl S13bb5MZ8EIQvp0lXUNr3WyJVA== X-Received: by 2002:a17:906:25d0:b0:7b2:bb8a:9622 with SMTP id n16-20020a17090625d000b007b2bb8a9622mr1763745ejb.72.1670503943153; Thu, 08 Dec 2022 04:52:23 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id fi22-20020a1709073ad600b007c0d4d3a0c1sm6477499ejc.32.2022.12.08.04.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 04:52:22 -0800 (PST) Date: Thu, 8 Dec 2022 13:52:21 +0100 From: Jiri Pirko To: Zhengchao Shao Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, johannes.berg@intel.com, dcbw@redhat.com, linville@tuxdriver.com, hs4233@mail.mn-solutions.de, weiyongjun1@huawei.com, yuehaibing@huawei.com Subject: Re: [PATCH] libertas: fix memory leak in lbs_init_adapter() Message-ID: References: <20221208121448.2845986-1-shaozhengchao@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221208121448.2845986-1-shaozhengchao@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Thu, Dec 08, 2022 at 01:14:48PM CET, shaozhengchao@huawei.com wrote: >When kfifo_alloc() failed in lbs_init_adapter(), cmd buffer is not >released. Add free memory to processing error path. > >Fixes: 7919b89c8276 ("libertas: convert libertas driver to use an event/cmdresp queue") >Signed-off-by: Zhengchao Shao Reviewed-by: Jiri Pirko