Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1108710rwb; Thu, 8 Dec 2022 06:54:16 -0800 (PST) X-Google-Smtp-Source: AA0mqf7SJ4NoM/YIFlBF0dORTuLicTo1UXoCkcMzq1rQUkXvfwsVSZv70WL4vVibibjA9AiiERyn X-Received: by 2002:a17:907:c787:b0:7ad:8035:ae3d with SMTP id tz7-20020a170907c78700b007ad8035ae3dmr22429836ejc.46.1670511256109; Thu, 08 Dec 2022 06:54:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670511256; cv=none; d=google.com; s=arc-20160816; b=0/wjEkQ4eTFDY8fqQ1yTQMEIKZ6dqhQog5POPa63Y7hok3fZE2DDFf0TJTw+uNE/3O yxm9E5ZNx6sIRFuDtUhtV25RA2GeBNq6tIT0Xf4nA6Pcmv/HZ5FweHXClS4MG+cfD7xl yR2SfHuU7qWkIewOfff/tG660YK3xLnxyIDrClbr4gGEDKJsC0IfFTq6TUuy/1qHoXWX AmGY+H2WZBl7TNP/X7QkNlXhrCVP9q/IS3ONWtZ1tuIted+VfVCTBmfHxmm4stuwNWs+ EuVsmS5eTGx+E9ErWO1kzy1ZAqHSshPuxgaoFcdJXrxPs6w+2JtGmuPZzahZihb5zDMn TYCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=9FI9wtgTtzPEKdXqyDGv8iCqz7MTaL2FyhDbU7wt4GE=; b=LLQHRQ+bINxVzjQi7ofu6JQxZeYphvbXKke8EB7CxOTlKwAERwoZF6sV0YK5pk+rKE Y9E84NKi5yeGQVfVYd1l19wSIcYj1MJD5fop+zX7JO8YgaY8yLF0L6R8MBlI8ndhPJen 7j8Y77j2jUMHTNiAUo0HhiE+ZIucxVzcF8lLF5YGVYJLKidOwqlyZEkhIShscjNPU9UQ krJf0G1NiEVMFqVHixlLJ6/Vjb5VGztu/4sQf1kHGj8FmIpjI+i0165SvLUthT8Jcyso 8Iixs+L+w4RjeqGNT31AfVv+k8WFx1ssE2US6AAcM8Ht8Ps6uzMpThlVHFZvpEGsGHAb 1CWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aGIkVTiJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ca12-20020aa7cd6c000000b0046aa75bee2dsi6147825edb.367.2022.12.08.06.53.35; Thu, 08 Dec 2022 06:54:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aGIkVTiJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbiLHOwv (ORCPT + 65 others); Thu, 8 Dec 2022 09:52:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbiLHOwu (ORCPT ); Thu, 8 Dec 2022 09:52:50 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 108BA17438; Thu, 8 Dec 2022 06:52:48 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ADB2CB82432; Thu, 8 Dec 2022 14:52:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DC95C433D7; Thu, 8 Dec 2022 14:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670511165; bh=Mq2R6tTzaLZHrS/2fNvvpXKjwej8WUo7ipuT20ESI7s=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=aGIkVTiJaQHVDQAGZDUqhXdZsqfl01Mczv+LhqOGvz0gLrfwSANLc2F/J8V1wn9DM YKCmOMzgooyUzNnRRsgWVZBv1dyi8JxMDhMdBAJkVYaCxJ3oUsRO01aApytezYucd1 WZolOc8WHN0LpOJ/IczO9A2Tz4z9qznC/NUf1lvMXWgr6hh5rV6T814OXxxCKV8+AU 9AZjtd85WXQ2ykYoyBZzbA8aHM0g8lfBE+xjwcuXJRQBX+ODhbwjoTfRypFMIeMIUs 8n4irQZfEPwz6CBFEwZe900K+OczBfsAnxGbRU8WwdH8Lo1w2G3eCoAgvmx+j/BsR5 k8aJ9P2VhRw1Q== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: wifi: rtlwifi: rtl8192se: remove redundant rtl_get_bbreg() call From: Kalle Valo In-Reply-To: <20221205085342.677329-1-pkosyh@yandex.ru> References: <20221205085342.677329-1-pkosyh@yandex.ru> To: Peter Kosyh Cc: Ping-Ke Shih , Peter Kosyh , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167051116096.9839.6828382275039467511.kvalo@kernel.org> Date: Thu, 8 Dec 2022 14:52:42 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Peter Kosyh wrote: > Extra rtl_get_bbreg() call looks like redundant reading. The read has > already been done in the "else" branch. Compile test only. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Peter Kosyh > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 49ebca0d9018 wifi: rtlwifi: rtl8192se: remove redundant rtl_get_bbreg() call -- https://patchwork.kernel.org/project/linux-wireless/patch/20221205085342.677329-1-pkosyh@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches