Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1967091rwb; Thu, 8 Dec 2022 18:12:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf5AfAh0Uexp/FnAtM5FJs0SBANjWqDzT6QKPsoad0xKb64RnPQr9j/zZIdFeMZUmpgbT6FO X-Received: by 2002:a17:906:381:b0:78d:f455:c39b with SMTP id b1-20020a170906038100b0078df455c39bmr3475486eja.65.1670551956119; Thu, 08 Dec 2022 18:12:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670551956; cv=none; d=google.com; s=arc-20160816; b=oMIT0OfzDVlb5bwX66uikdg6jCt3BoIs/b+clmdLvI2EltzmVyJPeaQIMt9ok3g5aa +U2llxfxDp++CG0LNGilRkZhGIzyhqj72o77Lc7H5yrV7JNnQL0+gvajYY8u06OCtXXY aoa4sWmfzrlR/YKrOhyQn7nYNKWrRE5/hyJQOVXWBn9y/Ee1z7RUo4dbj/p05Ebbn+f+ TOIQukVK60rDZz+OQD9YWj7PIdQaaKxONEasiY4zZUuA2dZi4t+It1zKQWp299JikXPg YGd7VNpQ9rdda5GAhzhXORm5mgZX7VK8/NTMvlU3SjnhW85FxlBX9f83Md/nJ2f71naX RgTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :authenticated-by; bh=fYXyESTjSR+VpJo6GmtVprr0KPMzpAxBpodDiDgtSy4=; b=pdF2FdQPxVh+hm+3nsPApeERavvUVujw1LqKN3zrtHA4Q7141MA4i4+DdctLQzUU6r nRDg34x1Smgy8fjwaObvLccpqKcNbTVGVyOo9vP/GDA5D/7rQswPSav88TgpjeL96Pfs 0JxAoZ1Ao2w3/RXpj3aoVXC6Y/raVtsSd3GDRAtvqzOCIKNZlj6zjjlEQGjsWxdY7NaP 3UANaro+H3jJunJvBRnSzTKxEWID83ALD9s8+2nIYgXg/BwP3uqLUvJLEjrMJwN7ihdo R7onAun9x4CoL0P2Ndy598uhnLWSAEv3QKckNklV2bXT6qBy1maOahTB0uZC/KEhoT7y f+eA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp23-20020a1709073e1700b007c1031bec6esi46647ejc.857.2022.12.08.18.12.16; Thu, 08 Dec 2022 18:12:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbiLICLA (ORCPT + 65 others); Thu, 8 Dec 2022 21:11:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiLICK6 (ORCPT ); Thu, 8 Dec 2022 21:10:58 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 155CC7665 for ; Thu, 8 Dec 2022 18:10:54 -0800 (PST) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 2B929xGX2005371, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 2B929xGX2005371 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=FAIL); Fri, 9 Dec 2022 10:09:59 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 9 Dec 2022 10:10:47 +0800 Received: from localhost (172.21.69.188) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Fri, 9 Dec 2022 10:10:46 +0800 From: Ping-Ke Shih To: CC: Subject: [PATCH 1/3] wifi: rtw89: 8852c: rfk: correct DACK setting Date: Fri, 9 Dec 2022 10:09:38 +0800 Message-ID: <20221209020940.9573-2-pkshih@realtek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221209020940.9573-1-pkshih@realtek.com> References: <20221209020940.9573-1-pkshih@realtek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [172.21.69.188] X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) X-KSE-ServerInfo: RTEXMBS04.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: trusted connection X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Deterministic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 12/09/2022 01:50:00 X-KSE-AttachmentFiltering-Interceptor-Info: no applicable attachment filtering rules found X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: =?big5?B?Q2xlYW4sIGJhc2VzOiAyMDIyLzEyLzkgpFekyCAxMjoyMzowMA==?= X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org After filling calibration parameters, set BIT(0) to enable the hardware circuit, but original set incorrect bit that affects a little TX performance. Fixes: 76599a8d0b7d ("rtw89: 8852c: rfk: add DACK") Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c b/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c index 60cd676fe22c9..f5b0b57f33207 100644 --- a/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c +++ b/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c @@ -337,7 +337,7 @@ static void _dack_reload_by_path(struct rtw89_dev *rtwdev, (dack->dadck_d[path][index] << 14); addr = 0xc210 + offset; rtw89_phy_write32(rtwdev, addr, val32); - rtw89_phy_write32_set(rtwdev, addr, BIT(1)); + rtw89_phy_write32_set(rtwdev, addr, BIT(0)); } static void _dack_reload(struct rtw89_dev *rtwdev, enum rtw89_rf_path path) -- 2.25.1