Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5620486rwb; Sun, 11 Dec 2022 09:15:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf51Tb9VObMu0rJlmaMg6xdxBE1kDd6s5jJ+LBsk6tlJlV9JEdqa0UhcF050nE/3wp0fS1S3 X-Received: by 2002:a62:19c6:0:b0:576:cd93:2b06 with SMTP id 189-20020a6219c6000000b00576cd932b06mr13772498pfz.6.1670778953591; Sun, 11 Dec 2022 09:15:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670778953; cv=none; d=google.com; s=arc-20160816; b=mzBvjQdZYZq8PO+boesn0yM68XHyiy1DzOUsDiLe+eIKZhMr14N3gifmxdJmiBMVpM Y+bzFbmaba2NyDEuHPXCqafkjMV3dQVqfrJ2eDlJhGfwOiJESeozGBtFxP9klFyx0czX pmY+TFYmVjydN9T2GAuOqWOc3VunyVMAQfSVhFjjNEAPWDZzyoqYxAk2WYV5bWhJyjYY nViKU07zAwp0NBqzzc/mwpYnZeld4RsaAvpwHbMoP+mBh9QgkFz44EpiLYBiTxYEP5eG DSz7hXaGABb17s1Npsr8BXxecZkIcAU9Ngx0j7lJ7EwaTaSSUCZdx2a837mz60cw6fXh JAcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1nt6EAlhgk2nwkDPstF6IhZZw1aP5T5mZpnCqYziP7o=; b=EcTT7+nAKJ/rZ5SRNat3S+MnQF7h3Ik9E6R6Img9fvOif6dmJ34V9y10B0p/nJgSe3 7x2k+7X9t90CUdZHC5UY1K9+N8FPmfmwyqx1EaGRZx14wCWzLb3NhYA1utsI+FwPzyji zAgIyzPUWXNu0Rl0mi/PP+KPbkR9FA6y8IrJTnEbZt6ZdHAZkQv2r5G2WCYoO0xk/tzV 2CTpC5k0MvMIDT4Ji8euBGrUCU+RcbdPuOkkxekACW7iGLoC389o2YXZa7KfI+vOyAYQ hIO94VyfwaRwCd9qEReS7NxXrh/fATM3GjMVFwJTGZotDkVmi8kPzOtoOWbkZh1HB4T9 /yAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=jWSVbUMI; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d16-20020a056a0010d000b00571a681de73si7749152pfu.293.2022.12.11.09.15.40; Sun, 11 Dec 2022 09:15:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=jWSVbUMI; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230311AbiLKRM4 (ORCPT + 66 others); Sun, 11 Dec 2022 12:12:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229947AbiLKRMy (ORCPT ); Sun, 11 Dec 2022 12:12:54 -0500 Received: from mx4.wp.pl (mx4.wp.pl [212.77.101.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08718BC9F for ; Sun, 11 Dec 2022 09:12:50 -0800 (PST) Received: (wp-smtpd smtp.wp.pl 1523 invoked from network); 11 Dec 2022 18:12:42 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1670778762; bh=1nt6EAlhgk2nwkDPstF6IhZZw1aP5T5mZpnCqYziP7o=; h=From:To:Cc:Subject; b=jWSVbUMIFVjE+7EiQSTW3N63va1NWmtV/kPcfoq4IhVuTtEfin9Pv8sNX7SBLIs+L bLhN8AZMu4rTJlG4MxQK+zIRmIXP/4oic3G2h99gUC+j6BAgLTltvzLpEwzucx5p/B ndoVa0wtE4035zQ7lPpodF103b3ArWk9WZg8Pnac= Received: from 89-64-15-29.dynamic.chello.pl (HELO localhost) (stf_xl@wp.pl@[89.64.15.29]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 11 Dec 2022 18:12:42 +0100 Date: Sun, 11 Dec 2022 18:12:42 +0100 From: Stanislaw Gruszka To: Yang Yingliang Cc: kvalo@kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH] wifi: iwlegacy: common: don't call dev_kfree_skb() under spin_lock_irqsave() Message-ID: <20221211171242.GA810227@wp.pl> References: <20221207144013.70210-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207144013.70210-1-yangyingliang@huawei.com> X-WP-MailID: 13ccd522ca636df53a1aea510e9fbb0c X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [EaOF] X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Dec 07, 2022 at 10:40:13PM +0800, Yang Yingliang wrote: > It is not allowed to call consume_skb() from hardware interrupt context > or with interrupts being disabled. So replace dev_kfree_skb() with > dev_consume_skb_irq() under spin_lock_irqsave(). Compile tested only. > > Fixes: 4bc85c1324aa ("Revert "iwlwifi: split the drivers for agn and legacy devices 3945/4965"") > Signed-off-by: Yang Yingliang Acked-by: Stanislaw Gruszka