Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp881779rwb; Wed, 14 Dec 2022 04:09:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf6cAfkXD4vw5UeGszkLkKOxWroe6QlbBXUCoFLFdL819ts1Uy9+qEQko3U5b+mogR7RMesy X-Received: by 2002:a05:6a20:bca8:b0:ae:7f1d:1912 with SMTP id fx40-20020a056a20bca800b000ae7f1d1912mr3214672pzb.38.1671019788427; Wed, 14 Dec 2022 04:09:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671019788; cv=none; d=google.com; s=arc-20160816; b=1HcP1mvCbIp1RW5OKXLhtEFvZxSuuQS1o4bXE5q9izLXtfo8KL3Eu+smDS7qsrMyqE ubORSn66FBRPuraW/Fq8isikzhvlMgbhK1qGOmY59E6qlM/Ro+AqWRIbcYa599sZR/UZ HzvtCDZk/XQBi6pSsbUQJqgtiXe0AtN1IQY4kfrv4osyP8ifVHtsZO9s5o/DaUUU6qvR 8KOVQeBnYgYGC73EUyMcyh3W06G+ytCY+OL8ED+Rv47lgTDl5ug1BrfB37e89x8r+/X2 QHk0EmvT31Ik3q7WLAUfw0KS9I9DIjUp/yXezokyKq5lPXBP7da5mM/XOfxoRLL9orLq HTAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:user-agent:references:in-reply-to:subject:cc:to :from:dkim-signature; bh=0xqfWBrK+AE0vSa5NV/a8hbMbqzYvsyfKzT5NUN5nuk=; b=uOobKwWzXGS8FRrG/fAs/cSOm4AYvnbnuegpItQgd6mlhQq5Rq/UyFP9kSlvmr3hHL yXgye6BhbketB4oPWDZWq51LkegjEJRjYTXGNuBXxDRIrP5r9jjrm08L1dyz0V3smggv NCI3lnb7dyco7g2qU2/Fja+7orvUAC2XS/ZRx0WLPaDYaUFHUNDE9rFz7DnXhKY8dun9 gVC7214bvRo7zwh2vfQNDfuUITfOJiiUdgtI0SDB73/s7+8RgaJlo06sAd92xr6Tk/HF zaV1IF9lwXgXp1sbu/Ff+Yi09Zcox25TxfOnjUfsV/3JFWcJpvgxr1opzGmrE0m66Dkq 1nAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MvHd4l6Y; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pq3-20020a17090b3d8300b00218641b1acdsi1701246pjb.68.2022.12.14.04.09.35; Wed, 14 Dec 2022 04:09:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MvHd4l6Y; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238277AbiLNMDI (ORCPT + 66 others); Wed, 14 Dec 2022 07:03:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237325AbiLNMCk (ORCPT ); Wed, 14 Dec 2022 07:02:40 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E6C827143 for ; Wed, 14 Dec 2022 04:01:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ECAB8B818A5 for ; Wed, 14 Dec 2022 12:01:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74D5BC433F0; Wed, 14 Dec 2022 12:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671019310; bh=0xqfWBrK+AE0vSa5NV/a8hbMbqzYvsyfKzT5NUN5nuk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MvHd4l6Y462o8hVAXWWmwgqnesqJ3WnO0cNKVSzR1e1WLXqBxoRdSCfY6+JjXL0xe gpnBa/Axjf4sBnQYO8apLi10UrODpzo2F1vQYlMUsV16XTB4fcnWTBrepiXJhsUVHn BV8BRDENXujmm/qOWVn7t3ZM5zLX9fhwp9f+T2t1Rc+GO+V3RZA/mtm5um8rsFl2C/ aFPlcd2fDrHawUHnzNw27XIEiDEvVjEX7JjvMgrMYNS/60ATbspD8AcmwyJg4hU9wV YRzHsR2wjVkaVzsEks/1h1sEfvTKFhmIlAOzXNA8v+iDClhv9vjwvTEdeef/GYMA7a ToOR6zVN+1NNA== From: Kalle Valo To: gregory.greenman@intel.com Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org, Johannes Berg , =?utf-8?B?w43DsWlnbw==?= Huguet Subject: Re: [PATCH] wifi: iwlwifi: fw: skip PPAG for JF In-Reply-To: <20221213225723.2a43415d8990.I9ac210740a45b41f1b2e15274e1daf4284f2808a@changeid> (gregory greenman's message of "Tue, 13 Dec 2022 23:15:04 +0200") References: <20221213225723.2a43415d8990.I9ac210740a45b41f1b2e15274e1daf4284f2808a@changeid> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Wed, 14 Dec 2022 14:01:45 +0200 Message-ID: <878rja19ee.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org gregory.greenman@intel.com writes: > From: Johannes Berg > > For JF RFs we don't support PPAG, but many firmware > images lie about it. Always skip support for JF to > avoid firmware errors when sending the command. > > Reported-and-tested-by: =C3=8D=C3=B1igo Huguet > Link: https://lore.kernel.org/linux-wireless/CACT4oufQsqHGp6bah2c4+jPn2wG= 1oZqY=3DUKa_TmPx=3DF6Lxng8Q@mail.gmail.com > Signed-off-by: Johannes Berg > Signed-off-by: Gregory Greenman > --- > > This is a fix for a firmware assert. It can wait until the next RC of v6.= 2. Ok, I'll take this to wireless tree. > Kalle - should I send a pull request for it? Thanks! For patches to the wireless tree I prefer that I take them directly. What I recommend is to assign the patch to me on patchwork and add "v6.2" to the subject like this: [PATCH v6.2] wifi: iwlwifi: fw: skip PPAG for JF That way I'll then apply it automatically. But this for future patches, I have now assigned this patch to me. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes