Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp910041rwb; Wed, 14 Dec 2022 04:30:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf6Qnwa4n68SHLnLWEf1Xe1vVnSMMPeGaIawu979xLRbP5CW3P2dhq14KleMB+wp/0FFrGj0 X-Received: by 2002:a17:903:324a:b0:189:854a:fff3 with SMTP id ji10-20020a170903324a00b00189854afff3mr24154993plb.23.1671021010864; Wed, 14 Dec 2022 04:30:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671021010; cv=none; d=google.com; s=arc-20160816; b=tvfIUN+3DVnYftTv5zGploRmAuOKSfORY/DCrgHtiQNFMCttQ5+YWG1FohIEbCzvHL +eulhGMLnBINQ0+952U2GlVo7MpAj7fQK1FLwkxvekrUb/6FBGR+rz9sgpCTdkayOBoP j3Aq5fTufeRZgK2wyAVGvL97r0sAt2G5vW+hiuIHhKuZaqCNWG/HsO+giAMhZDmz/tqe Us4pssCUZAIDQk0bRn5/c0yCB66FS14vsM9LrdqFvhJ01cUbfNiBVU3U+UJ1Ws9rWyWx GLnAgruUJqWbBsh9/Acs52QZtlkddN7WgFxOynb8nMXdyOIVk71336fBM2HCR20DaSUy O6OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=wRRccy/gdM8RtXMobJnyP3aPmuCJbTWrYD/s7/txtPU=; b=Y4NMxAaceYoUxRIW03cCh6mavYR5t7OIintsUYq68/RAPaVsn3j96yl1qc86FGGwZG OkDNY7HJofn5RJIZJMRwAOGCVCi6EvMltP2yGC4DLwEB2vmOB4oQbTtgzICCDv8fq6C1 9D+oGPfPg6hnD4t1DbG4tFlNrIWV2ZuQw9MDHN0O8tka7QHnuVOMHvIAFra3sLoUFb+i 4g4IDD8lzYzD2Ltdsq4ApdtQgICGtFe1TXPVuLwm3mY2r/Ci3DsQwgxbRHaDaNfsOsdr ex1i1su4fd+AzljkxUTI1rtATRQsN4t1yiH0MI3cMjbUKhsislEkzILwyyENzmokwiHh Ig+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L3PkEXwo; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h5-20020a170902f7c500b001897545cb86si2502169plw.76.2022.12.14.04.30.02; Wed, 14 Dec 2022 04:30:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L3PkEXwo; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238358AbiLNMYo (ORCPT + 66 others); Wed, 14 Dec 2022 07:24:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238117AbiLNMYV (ORCPT ); Wed, 14 Dec 2022 07:24:21 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00BE926AD0 for ; Wed, 14 Dec 2022 04:21:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1E06BCE1867 for ; Wed, 14 Dec 2022 12:21:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42AE6C433EF; Wed, 14 Dec 2022 12:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671020494; bh=a5ReCZw6A9g0RhWDRWu/w5e3rqlfxW02iE6V7iVb1X0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=L3PkEXwoJcydCVOIARyxPlHVNwO+RBOWVEA4D7wAmhrdRaERG9bujQY2t9WlCYNnb 38+KBkQvtlggvUWEeerbuJQ2sphsgZyVSKkC53/8Bojq1TzkZJBnWRVRa/2/+bTdv3 M8qiAS+plAlbjZQgWzLpmyF3NOy1igAdhRbJ73DXQKBi7tcSX7CwqIghg+AFw055Zy VzAsd+5gNa7j7cacFHncTF/I6lT46yGq+JNSrqxWNCua2vKO9cwbHyunTRaIaYINAP 9YEmZRx5/1QdD40BLMeZ+6Hmx5wX+ezp/ztQ28Cs5BOfv4zLI5jJU2Z8zx87ObBfS0 /x0GX5VYLLaJg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: iwlegacy: common: don't call dev_kfree_skb() under spin_lock_irqsave() From: Kalle Valo In-Reply-To: <20221207144013.70210-1-yangyingliang@huawei.com> References: <20221207144013.70210-1-yangyingliang@huawei.com> To: Yang Yingliang Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167102049109.7997.1710189431829876997.kvalo@kernel.org> Date: Wed, 14 Dec 2022 12:21:33 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Yang Yingliang wrote: > It is not allowed to call consume_skb() from hardware interrupt context > or with interrupts being disabled. So replace dev_kfree_skb() with > dev_consume_skb_irq() under spin_lock_irqsave(). Compile tested only. > > Fixes: 4bc85c1324aa ("Revert "iwlwifi: split the drivers for agn and legacy devices 3945/4965"") > Signed-off-by: Yang Yingliang > Acked-by: Stanislaw Gruszka Patch applied to wireless-next.git, thanks. 0c1528675d7a wifi: iwlegacy: common: don't call dev_kfree_skb() under spin_lock_irqsave() -- https://patchwork.kernel.org/project/linux-wireless/patch/20221207144013.70210-1-yangyingliang@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches