Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH 1/2] wifi: rtl8xxxu: Fix assignment to bit field
 priv->pi_enabled
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <4368d585-11ec-d3c7-ec12-7f0afdcedfda@gmail.com>
References: <4368d585-11ec-d3c7-ec12-7f0afdcedfda@gmail.com>
To:     Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Jes Sorensen <Jes.Sorensen@gmail.com>,
        Ping-Ke Shih <pkshih@realtek.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <167102058278.7997.4051866904687241289.kvalo@kernel.org>
Date:   Wed, 14 Dec 2022 12:23:05 +0000 (UTC)
Precedence: bulk

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> Just because priv->pi_enabled is only one bit doesn't mean it works
> like a bool. The value assigned to it loses all bits except bit 0,
> so only assign 0 or 1 to it.
> 
> This affects the RTL8188FU, but fixing the assignment didn't make
> a difference for my device.
> 
> Fixes: c888183b21f3 ("wifi: rtl8xxxu: Support new chip RTL8188FU")
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

2 patches applied to wireless-next.git, thanks.

9e32b4a709f0 wifi: rtl8xxxu: Fix assignment to bit field priv->pi_enabled
639c26faf9b1 wifi: rtl8xxxu: Fix assignment to bit field priv->cck_agc_report_type

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/4368d585-11ec-d3c7-ec12-7f0afdcedfda@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches