Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp914148rwb; Wed, 14 Dec 2022 04:32:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf7zZ83vNMh3j8iTxGE8gQUQHbMfiEPNkE8u0eos8DvN5j5TIofG0Tvoumbh4mpx+i5z9EN8 X-Received: by 2002:a17:907:970c:b0:78d:f455:b4ba with SMTP id jg12-20020a170907970c00b0078df455b4bamr24709949ejc.33.1671021152937; Wed, 14 Dec 2022 04:32:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671021152; cv=none; d=google.com; s=arc-20160816; b=gaM+Kp1cAn5c5ElzSuqyyp5N91yyRI4M98I9IhecygLd5vvKDM+9kUIV4wUWkFKW6k Tbp60WdIpVGyG37xslUfM9PjzJeDmxX0JtPF5hljZtedX6oy38K31dlOyDbAN64hrKqU nuhlS4oocSQ0rvFfGm5ShDkiUkHZtXwRqx9dEjv/a5MeO63L6icKB+edqlmnuaDziYdQ WT7uE9sqi1UaKSuAjv5rsRlu7JrH1mX+iH6A/02idqWcW6dOilzQifzrv1EonTljZF9n 92SCmQzcxohTcj0+sSYUwTxFUTZNL0bbPxXNmCp8CnZd7QRx5EdAEI24dvhcgzbo47pC Z4/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=ilZfNAhCm7fAXxcSnENjTxsdjAt6ZXLCp/ztytALpRI=; b=zeEWfwUrDxnENDcnYtdbMA7MsQjMQ/DapscJOri/Hmc98jerspI++2u/SOHF7GUUXR ry49h5I9YmaWPace/3wGpoqLmjq9OdhkmQT8Xbm1jwPDnVtTMiSUMgDkZovT5/5mpraV Hx+DBhZsC9ddLyI24w6TbumkV/W3vWYyMo8agnhm/N8nDVFRTD7XaN47Obgiq2QXpvh7 vIzbfblgvDYZasw9GrELAgWQvQzKXwzdxaYCxGwl+J09JK3IegPJ+fwg6ck5omFDKnWx vLQAgHcEZB7ousoBoHzeczeRl9dXQ7dOCn3S0Goq4AV9I8mEdmk7smKSoXd6Nq5wgakE O3tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ppKdE7Yh; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z10-20020a056402274a00b00463cd7d6e7asi15658935edd.30.2022.12.14.04.32.15; Wed, 14 Dec 2022 04:32:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ppKdE7Yh; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238160AbiLNMZy (ORCPT + 66 others); Wed, 14 Dec 2022 07:25:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237918AbiLNMZb (ORCPT ); Wed, 14 Dec 2022 07:25:31 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B05202981A; Wed, 14 Dec 2022 04:22:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4CC8E619E1; Wed, 14 Dec 2022 12:22:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D50BC433EF; Wed, 14 Dec 2022 12:22:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671020553; bh=lUA3ej4Kq3cPTrBeqhTmtXKzFkDbZTjpqcOzdC+8+rQ=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=ppKdE7Yhsev4718vpf9N7sFiYviSXngUlPDw14KFCBHK+2PShV0Ps5pMmbKWn+bpG PTcSpmbmmyDMs5uIs4kaBvBHKaTKwiAdDD4vZhOPlD2ryDaqEtw6XKALFQxcI02dxX 6z2wA6Covjn7wiYZmq6f0isRk6+IkjTKMCU5/KAFj3qA1hzbrZGt1aWKkPk47Kiz21 oXM7/QK08PopcNZExelh+OrwnM+DQyzYiFjYPPRP7ZgdgonCobfXpbjAVRDJIDYpm4 PI4rxHQ0gUwrxbHZ0gBiXYBaxR1GxrjEsLe0xkLxJvfBDDWCQzaU1FujVIrQ384asp JDcg9yFyH+HbQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: wifi: libertas: fix memory leak in lbs_init_adapter() From: Kalle Valo In-Reply-To: <20221208121448.2845986-1-shaozhengchao@huawei.com> References: <20221208121448.2845986-1-shaozhengchao@huawei.com> To: Zhengchao Shao Cc: , , , , , , , , , , , , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167102054878.7997.15438501425115316737.kvalo@kernel.org> Date: Wed, 14 Dec 2022 12:22:30 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Zhengchao Shao wrote: > When kfifo_alloc() failed in lbs_init_adapter(), cmd buffer is not > released. Add free memory to processing error path. > > Fixes: 7919b89c8276 ("libertas: convert libertas driver to use an event/cmdresp queue") > Signed-off-by: Zhengchao Shao > Reviewed-by: Jiri Pirko Patch applied to wireless-next.git, thanks. 16a03958618f wifi: libertas: fix memory leak in lbs_init_adapter() -- https://patchwork.kernel.org/project/linux-wireless/patch/20221208121448.2845986-1-shaozhengchao@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches