Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2486348rwb; Fri, 16 Dec 2022 02:45:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf7izTa+kr4+vDAGmBLJZI4DBNv0Cbl8IwpuNSwfirWshEB5qAX4MyssD0hd9NWBUTB+k2wU X-Received: by 2002:a17:906:3a8c:b0:7ad:84c7:503a with SMTP id y12-20020a1709063a8c00b007ad84c7503amr28749042ejd.72.1671187528171; Fri, 16 Dec 2022 02:45:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671187528; cv=none; d=google.com; s=arc-20160816; b=V5pH8n72PTg0K50ZOluR6Bl9wk2CyzBo8uFauvD9OZOgLE1a+L8Yn2RsC9vOkFbqPJ tD3K7H5yWPkz6GSxcotx7+T7k6w9g4IjIKr6XxYv+XDOdNJDB6gMr/UrqGEPmKWoqHO4 PfWJ4twMhg8Hsl1YfMTwHY2Cd2H2ChV9W4/A3iJnLN5bJHBP+hYyF3iHNfSbdbuG+2/M 02EQb3j03kjFV20OrezvbEbiF7nwjs7dbgAyYIJUDk7HFsIVr760Sjj2yoqrwlFvHUeD sBbkiBGZozoj7sseaPv6c9q+lMjvQIksl3unbiWRhP2z2MTHPLVnsCC1wWU4S3cCtwUI OPCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=IO7t6HDpS4gyrMnFLpqrCSFzS3Wp1by7mz0WBP6NeHI=; b=cCRB1HPSwHDT6NO26o8Mi7ZL0tI5WytzeA7KO1wqp6FKbEeTBLaa/sSIB6qp0AWGki 1B7n8IMe8SJPnKV4o5O20OEhsN6XRZfUcvAXSb8HpqCkbXN2SOWKVZMUYBTcK8ITkvs9 VY474y9IaBeLcuvVvKT0T2tz+Ce512FISD+WXTsi5slZLDZD3dvOmB4zT2P4+Dh9G+IX /4dtWRR9+EQd+N6K7JVDfUwG+nLYrDEg8Z1oc5Bj6BHWNKSKZSQCLcGSiZPO/finF2Ym nRkXB1LBf7LYuZhvUgzk4e6rotbsyEFlwX4PebZWH5rh6W+b/nfmMoa6RA3ZnvwhTaYQ UJtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kVm0Cla2; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ww2-20020a170907084200b007bdfe3a6d8bsi2187337ejb.611.2022.12.16.02.45.09; Fri, 16 Dec 2022 02:45:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kVm0Cla2; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230110AbiLPKgs (ORCPT + 67 others); Fri, 16 Dec 2022 05:36:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbiLPKgr (ORCPT ); Fri, 16 Dec 2022 05:36:47 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D9F82EF22 for ; Fri, 16 Dec 2022 02:36:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE1C061CFF for ; Fri, 16 Dec 2022 10:36:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F1DEC433EF; Fri, 16 Dec 2022 10:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671187005; bh=QdJPW1es4pIi/AdIHAu/1rzhIl22O8T5oHinECl6AyY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kVm0Cla2OQY2OAc7Os2BX1R3pEQgzPfty9rBu5IzpqV4d+D3A8FERpqi2Mmsm9w0U sFv29JQ4KK/yXIHJf+uCt9nuypNa/9VeRyoURYDvzYO1GzgRNmUMNUNjKtHW9YBCGN iw1/gDQrpAOohEeo3uoe3+6AwzKVRP5LP+3M1leXOyjLLh5XlxbMapjWJHVggFK1jA sVKBUbB0XJ9AiiKrHfUWdps0ekeAE96nV4x1O0EuteT37jmQVKKRGsu0cbDVZi5uD5 BouCNdojSKbFMW0iE8cc8I9HwPGRz3wrjl5nYIvjtjR296i6lksr1u5Eqg+vBLsiz9 qkNoPEGnM+fcw== From: Kalle Valo To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net Subject: Re: [PATCH] wifi: mac80211: fix initialization of rx->link and rx->link_sta References: <20221215190503.79904-1-nbd@nbd.name> Date: Fri, 16 Dec 2022 12:36:42 +0200 In-Reply-To: <20221215190503.79904-1-nbd@nbd.name> (Felix Fietkau's message of "Thu, 15 Dec 2022 20:05:03 +0100") Message-ID: <877cyrljnp.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > There are some codepaths that do not initialize rx->link_sta properly. This > causes a crash in places which assume that rx->link_sta is valid if rx->sta > is valid. > One known instance is triggered by __ieee80211_rx_h_amsdu being called from > fast-rx. An example crash log would be nice to include, it would make it easier to find this fix. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches