Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <184255f9-426d-1718-5216-3eb44d21c7e3@nbd.name>
Date:   Fri, 16 Dec 2022 11:50:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.0
Subject: Re: [PATCH] wifi: mac80211: fix initialization of rx->link and
 rx->link_sta
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, johannes@sipsolutions.net
References: <20221215190503.79904-1-nbd@nbd.name> <877cyrljnp.fsf@kernel.org>
From:   Felix Fietkau <nbd@nbd.name>
In-Reply-To: <877cyrljnp.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16.12.22 11:36, Kalle Valo wrote:
> Felix Fietkau <nbd@nbd.name> writes:
> 
>> There are some codepaths that do not initialize rx->link_sta properly. This
>> causes a crash in places which assume that rx->link_sta is valid if rx->sta
>> is valid.
>> One known instance is triggered by __ieee80211_rx_h_amsdu being called from
>> fast-rx.
> 
> An example crash log would be nice to include, it would make it easier
> to find this fix.
Sure. Will add the one that was sent to the list yesterday to v3.

- Felix