Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <43bd3a96-7ed7-625a-cdf1-615f53373613@quicinc.com>
Date:   Mon, 19 Dec 2022 11:22:57 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH v12 2/4] mac80211: MBSSID support in interface handling
Content-Language: en-US
To:     Jouni Malinen <j@w1.fi>
CC:     <johannes@sipsolutions.net>, <linux-wireless@vger.kernel.org>
References: <20210916025437.29138-1-alokad@codeaurora.org>
 <20210916025437.29138-3-alokad@codeaurora.org>
 <20221218152420.GA906762@w1.fi>
 <441771f8-6269-0ce4-fce8-513f7f3f7d95@quicinc.com>
 <20221219191506.GA17184@w1.fi>
From:   Aloka Dixit <quic_alokad@quicinc.com>
In-Reply-To: <20221219191506.GA17184@w1.fi>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/19/2022 11:15 AM, Jouni Malinen wrote:
> On Mon, Dec 19, 2022 at 10:53:55AM -0800, Aloka Dixit wrote:
>> On 12/18/2022 7:24 AM, Jouni Malinen wrote:
>>> On Wed, Sep 15, 2021 at 07:54:35PM -0700, Aloka Dixit wrote:
>>>> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
>>>> +static int ieee80211_set_ap_mbssid_options(struct ieee80211_sub_if_data *sdata,
>>>> +					   struct cfg80211_mbssid_config params)
>>>
> @@ -1268,10 +1268,17 @@ static int ieee80211_start_ap(struct wiphy *wiphy, struct net_device *dev,
>   	if (sdata->vif.type == NL80211_IFTYPE_AP &&
>   	    params->mbssid_config.tx_wdev) {
>   		err = ieee80211_set_ap_mbssid_options(sdata,
> -						      params->mbssid_config,
> +						      &params->mbssid_config,
>   						      link_conf);
>   		if (err)
>   			return err;
> +	} else {
> +		/* FIX: Is this the correct thing to do here and under which
> +		 * conditions? At least ema_ap needs to be cleared for AP mode
> +		 * if mbssid_config.tx_wdev is not set. */
> +		link_conf->bssid_index = 0;
> +		link_conf->nontransmitted = false;
> +		link_conf->ema_ap = false;

Will need to clean MBSSID elements in stored beacon as well.
Would the two HWSIM testcases you mentioned earlier be sufficient for 
testing? I've never used P2P related tests, and in fact I only even ran 
one testcase at a time so stale configurations didn't show up.

Thanks.