Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp3565771rwj; Mon, 19 Dec 2022 21:38:27 -0800 (PST) X-Google-Smtp-Source: AMrXdXvIPW70wFrATGJjMyAdzaT3uQ2bZKTtulguSgBHH0HwitbI/4blr3P7k7cYBh8YICm85q1c X-Received: by 2002:a17:90a:9742:b0:219:c2f2:f818 with SMTP id i2-20020a17090a974200b00219c2f2f818mr7287819pjw.42.1671514707779; Mon, 19 Dec 2022 21:38:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671514707; cv=none; d=google.com; s=arc-20160816; b=qnsIqf6aIGelgVrOYOh3FHAgZRjuzu994pUvzHnFcMFOXYJ9ax/PMj43trQWKnoDpw zTvWjXuiRm79pSjwEeKSO7PIpsOfj8LyPNlPBAZO1+QmwVrkyg1WPTzLCH1dVYqrQsAK jxO34ktQEFcQBhhic6rTSUyQ9PS8fu4kjnWbR7phFAOgxA7e0B0tq4k0GU9TsnGBqJ+H oPcDRHt0bOR9ZnlXSAYCycJSWsduykiesWhRgdldXSjqrsX2/6I7n5bl9eFkddDzBxI4 YcG+R92S++iiEHyVTD5cZZfktbimAQ03oOREwEjpluKdW5KI1lsfLuNdbhTfMGvQqcoF yDsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=2vsjHRuKShoBU6UYxelWzJJm7vorrs4jvdxdWBQsX3M=; b=p1ceJomsgN0NYH551hrriav+VfUttG39EMvYsJh3kR3ymH4s/JFpvc896uPCkOkloT 3nGOcI1Zq0dhkElraQRkbzjz3N6KSipSezjEapC3mZ97UnuDxJBqWQohKCVbezKpmVDk FB4TXf3oZYWZffH9YmB5vJNbt2vMCV7OFGc/2gsrCRzeXmPjeKZcRlv0k7szBmu9DeUw hIJPqJ2kb0Hq/Lo0VrgcbAefThBq4Q4etnHEKOg6zYj6Oh62umW/7jZ6U1DEpN+V7U2p UTkFTCaXIEx9gXZuWr5XKbmMKXvQAIrc4hzT9eKQCxn70Ehi/pHuEDSCHYJ4RSS0DDWa ea5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="S/GuIsI5"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hi9-20020a17090b30c900b001fab0d18bcasi12375521pjb.66.2022.12.19.21.38.15; Mon, 19 Dec 2022 21:38:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="S/GuIsI5"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232605AbiLTFWG (ORCPT + 66 others); Tue, 20 Dec 2022 00:22:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbiLTFWE (ORCPT ); Tue, 20 Dec 2022 00:22:04 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77B0AE98 for ; Mon, 19 Dec 2022 21:22:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E4134B811A0 for ; Tue, 20 Dec 2022 05:22:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97459C433D2; Tue, 20 Dec 2022 05:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671513720; bh=UWGvh2JUZ0jx1HU4zNMWvYvYZFGyAGXD3NbJ52DBNpM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=S/GuIsI5d4UjVdwLSKXSKbYlbB3JhxI/GeoZIsEtPPqsxAn3UP8/89q9I4vMV83II h8qkodCmjdaoPeWEdvpADH/jRSlWoynOqosO9pA1AOyFV2H1Or45YCgRzC5h9H+mny YZ78jDyaVjuVa+qztwyFFpuVm6SxHWHlSKBqkG5np9tMtchZ7QFJrabgyI7ECQnI5j C5VGH0JmRwgFTEN0R8bolIkrjVkeNx00vdSBkIBSd5SpU4TPItwOEjzY9monhyoTFw SjmtaPU9fSI2bg2U3w9eLYwwT54ZlZRxMxpAbAjqxF+Idpa+JyfjKqJb2SyYysd6/l qfz2RqsXat2fA== From: Kalle Valo To: Wenli Looi Cc: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= , linux-wireless@vger.kernel.org, Jeff Johnson Subject: Re: [PATCH] ath9k: remove most hidden macro dependencies on ah References: <87v8mcd7kh.fsf@toke.dk> Date: Tue, 20 Dec 2022 07:21:55 +0200 In-Reply-To: (Wenli Looi's message of "Mon, 19 Dec 2022 11:12:59 -0800 (PST)") Message-ID: <87sfhak5u4.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wenli Looi writes: > One thing I just noticed is that when compiling with CONFIG_ATH_DEBUG, > there is one slight difference in the binary because of this change: > > - "Timeout while waiting for nf to load: AR_PHY_AGC_CONTROL=0x%x\n", > - REG_READ(ah, AR_PHY_AGC_CONTROL)); > + "Timeout while waiting for nf to load: AR_PHY_AGC_CONTROL(ah)=0x%x\n", > + REG_READ(ah, AR_PHY_AGC_CONTROL(ah))); Good catch, I can remove the "(ah)" from the string in the pending branch. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches