Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2 2/3] wifi: ath11k: add support to parse new WMI event
 for 6
 GHz
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20221214164639.31542-3-quic_adisi@quicinc.com>
References: <20221214164639.31542-3-quic_adisi@quicinc.com>
To:     Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        Aditya Kumar Singh <quic_adisi@quicinc.com>,
        Lavanya Suresh <quic_lavaks@quicinc.com>,
        Wen Gong <quic_wgong@quicinc.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <167162704604.23347.8011938867680129068.kvalo@kernel.org>
Date:   Wed, 21 Dec 2022 12:50:48 +0000 (UTC)
Precedence: bulk

Aditya Kumar Singh <quic_adisi@quicinc.com> wrote:

> In order to support different power levels of 6 GHz AP and client,
> new WMI event for regulatory - WMI_REG_CHAN_LIST_CC_EXT_EVENTID is
> added in firmware. This event provides new parameters required for
> 6 GHz regulatory rules.
> 
> Add support for parsing 2.4 GHz, 5 GHz and 6 GHz reg rules and other
> parameters from WMI_REG_CHAN_LIST_CC_EXT_EVENTID.
> 
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
> 
> Reported-by: kernel test robot <lkp@intel.com>

I don't think using Reported-by is correct here. You are
adding a new feature, not fixing a bug reported the bot.

> Signed-off-by: Lavanya Suresh <quic_lavaks@quicinc.com>
> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

This patch added new checkpatch warnings, they were too complex for me to fix them:

drivers/net/wireless/ath/ath11k/reg.c:678: line length of 92 exceeds 90 columns
drivers/net/wireless/ath/ath11k/wmi.h:4090: Please don't use multiple blank lines
drivers/net/wireless/ath/ath11k/wmi.h:4212: line length of 92 exceeds 90 columns
drivers/net/wireless/ath/ath11k/wmi.c:5002: line length of 91 exceeds 90 columns
drivers/net/wireless/ath/ath11k/wmi.c:5102: line length of 94 exceeds 90 columns
drivers/net/wireless/ath/ath11k/wmi.c:5208: line length of 91 exceeds 90 columns
drivers/net/wireless/ath/ath11k/wmi.c:5209: line length of 92 exceeds 90 columns
drivers/net/wireless/ath/ath11k/wmi.c:5235: line length of 95 exceeds 90 columns
drivers/net/wireless/ath/ath11k/wmi.c:5298: line length of 91 exceeds 90 columns

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20221214164639.31542-3-quic_adisi@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches