Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c73a9b25-f7b7-5265-7a86-8b599aaa6df9@quicinc.com>
Date:   Wed, 21 Dec 2022 18:24:59 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH v2 2/3] wifi: ath11k: add support to parse new WMI event
 for 6 GHz
To:     Kalle Valo <kvalo@kernel.org>
CC:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        "Lavanya Suresh" <quic_lavaks@quicinc.com>,
        Wen Gong <quic_wgong@quicinc.com>
References: <20221214164639.31542-3-quic_adisi@quicinc.com>
 <167162704604.23347.8011938867680129068.kvalo@kernel.org>
Content-Language: en-US
From:   Aditya Kumar Singh <quic_adisi@quicinc.com>
In-Reply-To: <167162704604.23347.8011938867680129068.kvalo@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/21/2022 18:20, Kalle Valo wrote:
> Aditya Kumar Singh <quic_adisi@quicinc.com> wrote:
> 
>> In order to support different power levels of 6 GHz AP and client,
>> new WMI event for regulatory - WMI_REG_CHAN_LIST_CC_EXT_EVENTID is
>> added in firmware. This event provides new parameters required for
>> 6 GHz regulatory rules.
>>
>> Add support for parsing 2.4 GHz, 5 GHz and 6 GHz reg rules and other
>> parameters from WMI_REG_CHAN_LIST_CC_EXT_EVENTID.
>>
>> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
>> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
>> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
>>
>> Reported-by: kernel test robot <lkp@intel.com>
> 
> I don't think using Reported-by is correct here. You are
> adding a new feature, not fixing a bug reported the bot.
Bot did report a bug in v1 Kalle. That I fixed in v2.

> 
>> Signed-off-by: Lavanya Suresh <quic_lavaks@quicinc.com>
>> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
>> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> 
> This patch added new checkpatch warnings, they were too complex for me to fix them:
> 
> drivers/net/wireless/ath/ath11k/reg.c:678: line length of 92 exceeds 90 columns
> drivers/net/wireless/ath/ath11k/wmi.h:4090: Please don't use multiple blank lines
> drivers/net/wireless/ath/ath11k/wmi.h:4212: line length of 92 exceeds 90 columns
> drivers/net/wireless/ath/ath11k/wmi.c:5002: line length of 91 exceeds 90 columns
> drivers/net/wireless/ath/ath11k/wmi.c:5102: line length of 94 exceeds 90 columns
> drivers/net/wireless/ath/ath11k/wmi.c:5208: line length of 91 exceeds 90 columns
> drivers/net/wireless/ath/ath11k/wmi.c:5209: line length of 92 exceeds 90 columns
> drivers/net/wireless/ath/ath11k/wmi.c:5235: line length of 95 exceeds 90 columns
> drivers/net/wireless/ath/ath11k/wmi.c:5298: line length of 91 exceeds 90 columns
> 
Sure Kalle, let me see how I can fix this.