Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?utf-8?B?U3VqdWFuIENoZW4gKOmZiOe0oOWonyk=?= 
        <Sujuan.Chen@mediatek.com>
To:     "lorenzo@kernel.org" <lorenzo@kernel.org>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        =?utf-8?B?U2hheW5lIENoZW4gKOmZs+i7kuS4nik=?= 
        <Shayne.Chen@mediatek.com>,
        =?utf-8?B?Qm8gSmlhbyAo54Sm5rOiKQ==?= <Bo.Jiao@mediatek.com>,
        "nbd@nbd.name" <nbd@nbd.name>,
        =?utf-8?B?RXZlbHluIFRzYWkgKOiUoeePiumIuik=?= 
        <Evelyn.Tsai@mediatek.com>, Ryder Lee <Ryder.Lee@mediatek.com>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2] wifi: mt76: fix potential memory leakage
Thread-Topic: [PATCH v2] wifi: mt76: fix potential memory leakage
Thread-Index: AQHZE2UYm26GeWDuU0a5b6k/XQDcva50+UQAgAE64oCAAfJmgIAASTAA
Date:   Wed, 21 Dec 2022 14:48:19 +0000
Message-ID: <3940cc5ccb4b17d51b5176e722daef0d1af66d6a.camel@mediatek.com>
References: <0a218783098a6b1b90ff120c7182acee93dc8feb.1671423784.git.Bo.Jiao@mediatek.com>
         <Y6A1Et1yzcWnWhpy@lore-desk>
         <9d8aa92e3650128c94af91435a222c00ff2acb1c.camel@mediatek.com>
         <Y6LfTUoSZ8W/gJ0Y@lore-desk>
In-Reply-To: <Y6LfTUoSZ8W/gJ0Y@lore-desk>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MWduSm5NZVZoSnE2MG9ScEZibEFhejJUaldqS1hOcG1Gb0tNNGlOQUV1Z1lR?=
 =?utf-8?B?c1RYY1NKc3dhWHcxdWYxVWxyVjNNeUp5UW5vSENuYUVxdkt0REpxalVOdWNH?=
 =?utf-8?B?Mk1sWkRRRHNFOUZMU1l5MWtLMkw0NktOTzY0K0RVbDJ5OXdJaXM1NWxYQUxY?=
 =?utf-8?B?NkRLaU82NVlMYlJ2V0s2SW1QQnFvNGhyUlF3N3hnK2JveVNNaWMyVUdvQ3A3?=
 =?utf-8?B?VnRQWExGV0oyWmdxUkRlbkV3UXhKbjUvWldjeVVFOWZXQjMrNFBod0NYZ2dS?=
 =?utf-8?B?TWNrYndQMEFjbkF3NXVMb0NzRkJKcktsRmdWKzZnaUtZOFg4SkppalU0OUVY?=
 =?utf-8?B?dy93UWNzeVgxakZ4RUxTZlM2em1SUDVFaFk5WnZUNDRteWhvbHNzdnA1ZGhz?=
 =?utf-8?B?d2dpaG90QzRpend6ZjRGcEdNOVNSaXFpWlVPd0w3aHFoT0gxSm1WUTRQNHR2?=
 =?utf-8?B?NVMrSk9MRXpEeFVqaUhJU3ltTXM3TGdPQWFOVGlxUEdndkVvdFNYT0RkNHJv?=
 =?utf-8?B?bitKMUpxUGRXbVRwUE95WnQrV1RYS1lLRzB5VWR6RVhZaS9MUmdMRytWRDFE?=
 =?utf-8?B?S0JobTlZN2ovc3BjS2lnS2VRRXFZRFVkMW1IQ1ZYSTFrWHhhNW1oTTRZem5l?=
 =?utf-8?B?amd0WmNsU21TSHhtMW9NR05PcndzQ2U2REVDMDIxazhBYVpMc2RJOGVydFF5?=
 =?utf-8?B?a1A4bmM3ajJoZFQyVDRBbWxTQkRuTHdaSnhuaG9JZ0FJQ3R0cWV4RzE3cllI?=
 =?utf-8?B?ellnQVMvK1drTy9GYVVHbm1PVHhqTitzZjZ5TGdrWERpT3VsUDZmTVRQUVJV?=
 =?utf-8?B?dHNJN3NPZXg3ZWs4eEltTWhXVmJwekhLMzBIM1pOSWN0elR0dklMT1hWUHRJ?=
 =?utf-8?B?dSttZktaYXNzcHhseFBPdVR6TXdUWDhSMVB6eTVYSjNGTE5hK0w0WHdnTVR2?=
 =?utf-8?B?RVFLYnAySXh1WENmcHZDUkxhQzFMcDh5ekhxWXJoUGtSRE8yV3RIVE5PbXJ1?=
 =?utf-8?B?UUs3MTdTeW52YXhFU2txbHpMbFMrY1VXanBxVDB5SGJMdzA4bFRURlZqekk3?=
 =?utf-8?B?UGovRjNnOTZwVnFJb0kraDQzZnFzNVRxNlQrc2FWVHQ1S055QmxzUzFpY0xU?=
 =?utf-8?B?eGpOZWhQdU15ODRYR0lzblJXZjl5WjJlRFZhZ3NWOHRoVTR2NTJQaG8wdGpW?=
 =?utf-8?B?RDhLSzJpeVU5ek5RNFN2VFc1bUFpeHB6cG14bDA3RTR1Z0syYlc5UEIwNlRj?=
 =?utf-8?B?VVVMRXdJMW5sTnY0aTRHR0U2ZUFQK3IwSW9ReWhZWElkY2djVFF4anF3UWF5?=
 =?utf-8?B?QnYzQ3VkSENvUm4wTFc4Zm4xVlh1aUI0QVRrTG5kTDQ1MmZ4UWFKQnBKdHcx?=
 =?utf-8?B?cldYK3VCYVc1Y1orZWM4dmg3NkpMUHlkSThvRzNhT05vbDJUZnprNE5RT1R5?=
 =?utf-8?B?TXliL0t4UjRVSmtlNzlhUnJWSWQ5WkJOdEV4MVRtQS9LdW9MSmhkMWY3YUNB?=
 =?utf-8?B?YUFDbXpuK1RFdnk2OHhZL3o3blgyQW1kM3BUb3JQK00xa3k5WGxuUW1XMmov?=
 =?utf-8?B?VXhGV0lYU3RoZEoycXJreUxYdlIwdmZpOW41cWU3OHhrZ2lMUEtMeC8zZjdP?=
 =?utf-8?B?QVIwcDNEL2d1b0F0RWlKM29ycmhSZ09iaDBOdWNXOGtpZm1pYURQbmRtc0lQ?=
 =?utf-8?B?TW5sWVgxYnZlcWxhRU42UHNzYmVEcTEwOHZhaDlzMTh4RVJwVW8yUzdBK3N0?=
 =?utf-8?B?UWZPbVFJTFRmdGI4VC9NRi9YZTVWejVPamROdE9RUHFIc1luWUM5R2ZZV3hj?=
 =?utf-8?B?anpNQ2d3YzUxcFJLY0hJV0ord3l1SU9TcnN3Vk45TG1mZEJQVFB6VmQrbFgw?=
 =?utf-8?B?YnNGNm8vM2gvT21TZ244T0tsdzlhN1NEa2I0dUNad0JrOThQTlBLMzBxcmpp?=
 =?utf-8?B?MUhuUGh6YitnSGV2RFJwNTRHakRXT0hwcE5IOUdkYkZIVTlxcXArVStrbE4w?=
 =?utf-8?B?NGdtQkM1REZ1V2R1UUFqNzFOb3E3ZWZ4MEFmZ0QxOFJ0Y05VbWQ4dVlrSnpO?=
 =?utf-8?B?ZFZTN1JLSk1GZjVYdE83cnlndTJjN3JYdkVkMzJkVUQzV0dkVlhMci9pWG5F?=
 =?utf-8?B?OU4vZ0VhWVVMQUkwcVFidXRtREVUOW5NdVAvWStnSnYzRWhBUDRDUXo0N1JV?=
 =?utf-8?B?L2c9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2C9B1A848BB6144CBFE453E4954B914F@apcprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PS1PR03MB3461.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bde30942-9b73-4e57-f006-08dae36266c8
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2022 14:48:19.6622
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YNoOIo2r/Dft4bNMe7cXAvVR+AUSOhecP+gV92PJp7IlgEEdrxvkSLmovvpaD7diRKYXvk7XmDF/5rsi6lzpHosIOCoxtfUxk+1cOgtFO3w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR03MB6611
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

T24gV2VkLCAyMDIyLTEyLTIxIGF0IDExOjI2ICswMTAwLCBsb3JlbnpvQGtlcm5lbC5vcmcgd3Jv
dGU6DQo+IFsuLi5dDQo+IA0KPiA+IEhpIExvcmUsDQo+IA0KPiBIaSBTdWp1YW4sDQo+IA0KPiA+
IA0KPiA+IHdlIGxvdmUgeW91ciBwYXRjaCwgYnV0IHdlIGhhdmUgYW5vdGhlciBwYXRjaCB0byBh
dm9pZCBtZW1vcnkNCj4gPiBmcmFnbWVudGF0aW9uIGJ5IGR1cGxpY2F0aW5nIHRoZSByeCBza2Ig
YWZ0ZXIgbXQ3Nl9kbWFfZGVxdWV1ZSgpLg0KPiA+IGl0DQo+ID4gcmVxdWlyZXMgbXQ3Nl9nZXRf
cnh3aSgpIGJlIHBsYWNlZCBiZWZvcmUgcGFnZV9mcmFnX2FsbG9jKCkuDQo+ID4gDQo+ID4gdGhl
IGJlbG93IHBhdGNoKG5lZWQgcmViYXNlKSB3aWxsIGJlIHNlbnQgYWZ0ZXIgdGhlIGN1cnJlbnQg
cGF0Y2gNCj4gPiBpcw0KPiA+IGFjY2VwdGVkLg0KPiA+IA0KPiA+IC0tLSBhL2RyaXZlcnMvbmV0
L3dpcmVsZXNzL21lZGlhdGVrL210NzYvZG1hLmMNCj4gPiArKysgYi9kcml2ZXJzL25ldC93aXJl
bGVzcy9tZWRpYXRlay9tdDc2L2RtYS5jDQo+ID4gQEAgLTM4Niw5ICszODYsMTEgQEAgbXQ3Nl9k
bWFfZ2V0X2J1ZihzdHJ1Y3QgbXQ3Nl9kZXYgKmRldiwgc3RydWN0DQo+ID4gbXQ3Nl9xdWV1ZSAq
cSwgaW50IGlkeCwNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTS0JfV0lU
SF9PVkVSSEVBRChxLT5idWZfc2l6ZSksDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgRE1BX0ZST01fREVWSUNFKTsNCj4gPiANCj4gPiAtICAgICAgICAgICAgICAgYnVmID0g
dC0+cHRyOw0KPiA+ICsgICAgICAgICAgICAgICBidWYgPSBwYWdlX2ZyYWdfYWxsb2MoJnEtPnJ4
X3BhZ2UsIHEtPmJ1Zl9zaXplLA0KPiA+IEdGUF9BVE9NSUMpOw0KPiA+ICsgICAgICAgICAgICAg
ICBpZiAoIWJ1ZikNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsNCj4g
PiArICAgICAgICAgICAgICAgbWVtY3B5KGJ1ZiwgdC0+cHRyLCBTS0JfV0lUSF9PVkVSSEVBRChx
LQ0KPiA+ID5idWZfc2l6ZSkpOw0KPiANCj4gV2UgdGhpcyBhcHByb2FjaCB3ZSBzdGlsbCBuZWVk
IHRvIGFsbG9jYXRlIHRoZSBidWZmZXIgKGluDQo+IG10NzZfZG1hX2dldF9idWYoKQ0KPiBpbnN0
ZWFkIG9mIG10NzZfZG1hX3J4X2ZpbGwoKSkgYnV0IHdlIG5lZWQgZXZlbiB0byBjb3B5IHRoZSBm
dWxsDQo+IGJ1ZmZlciB0aGF0DQo+IGNhbiBiZSBwcmV0dHkgZXhwZW5zaXZlIGluc3RlYWQgb2Yg
cmVseWluZyBvbiB0aGUgRE1BLCBzbyBJIHdvdWxkDQo+IGF2b2lkIHRoaXMNCj4gYXBwcm9hY2gu
DQo+IA0KDQpIaSBMb3JlLA0KDQpZZXMsIGl0IGlzIHNvIGV4cGVuc2l2ZSwgYnV0IGlmIG5vIG1l
bWNvcHksIGl0IHdpbGwgY2FzdWUgbWVtb3J5DQpmcmFnbWVudGF0aW9uICh3ZSBoaXQgdGhpcyBp
c3N1ZSBpbiBpbnRlcm5hbCBTUUMpLg0KDQphcyB3ZSBrbm93LCB3ZWQgbmVlZHMgdG8gZXhjaGFu
Z2UgcnggcGt0KGJlbG9uZ3MgdG8gd2VkIHJ4IGJ1ZmZlcg0KbWFuYWdlcikgd2l0aCB3aWZpIGRy
aXZlcihkbWEgcnggZGF0YSBxdWV1ZSkgYnkgZXhjaGFuZ2luZyB3ZmRtYSBkbWFkDQp0byBlbnN1
cmUgdGhlIGZyZWUgd2VkIHJ4IGJ1ZmZlci4NCg0KaXQgaXMgcG9zc2lhYmxlIHRoYXQgYSBsYXJn
ZSBudW1iZXIgb2YgYnVmZmVyIGhhcyBiZWVuIGV4Y2hhbmdlZCB0byB3ZWQNCmFuZCBjYW4gbm90
IGNvbWUgYmFjayB0byB3bGFuIGRyaXZlci4gU28sIHRoZSBtZW1vcnkgZnJvbSB0aGUgc2FtZSAz
MksNCnBhZ2UgY2FjaGUgaXMgdW5hYmxlIHRvIGJlIHJlbGVhc2VkLCBhbmQgaXQgd2lsbCBiZSBm
YWlsZWQgYXQNCnBhZ2VfZnJhZ19hbGxvYyBpbiBtdDc2X2RtYV9yeF9maWxsLg0KDQpBbnkgaWRl
YXMgYnV0IG1lbWNvcHnvvJ8NCg0KUmVnYXJkcywNClN1anVhbg0KDQo+IFJlZ2FyZHMsDQo+IExv
cmVuem8NCj4gDQo+ID4gICAgICAgICAgICAgICAgIHQtPmRtYV9hZGRyID0gMDsNCj4gPiAtICAg
ICAgICAgICAgICAgdC0+cHRyID0gTlVMTDsNCj4gPiANCj4gPiAgICAgICAgICAgICAgICAgbXQ3
Nl9wdXRfcnh3aShkZXYsIHQpOw0KPiA+IA0KPiA+IEBAIC01NjksNiArNTcxLDcgQEAgbXQ3Nl9k
bWFfcnhfZmlsbChzdHJ1Y3QgbXQ3Nl9kZXYgKmRldiwgc3RydWN0DQo+ID4gbXQ3Nl9xdWV1ZSAq
cSkNCj4gPiAgICAgICAgIHdoaWxlIChxLT5xdWV1ZWQgPCBxLT5uZGVzYyAtIDEpIHsNCj4gPiAg
ICAgICAgICAgICAgICAgc3RydWN0IG10NzZfdHh3aV9jYWNoZSAqdCA9IE5VTEw7DQo+ID4gICAg
ICAgICAgICAgICAgIHN0cnVjdCBtdDc2X3F1ZXVlX2J1ZiBxYnVmOw0KPiA+ICsgICAgICAgICAg
ICAgICBib29sIHNraXBfYWxsb2MgPSBmYWxzZTsNCj4gPiAgICAgICAgICAgICAgICAgdm9pZCAq
YnVmID0gTlVMTDsNCj4gPiANCj4gPiAgICAgICAgICAgICAgICAgaWYgKChxLT5mbGFncyAmIE1U
X1FGTEFHX1dFRCkgJiYNCj4gPiBAQCAtNTc2LDExICs1NzksMTkgQEAgbXQ3Nl9kbWFfcnhfZmls
bChzdHJ1Y3QgbXQ3Nl9kZXYgKmRldiwgc3RydWN0DQo+ID4gbXQ3Nl9xdWV1ZSAqcSkNCj4gPiAg
ICAgICAgICAgICAgICAgICAgICAgICB0ID0gbXQ3Nl9nZXRfcnh3aShkZXYpOw0KPiA+ICAgICAg
ICAgICAgICAgICAgICAgICAgIGlmICghdCkNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGJyZWFrOw0KPiA+ICsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICBpZiAodC0+
cHRyKSB7DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBza2lwX2FsbG9jID0g
dHJ1ZTsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJ1ZiA9IHQtPnB0cjsN
Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICB9DQo+ID4gICAgICAgICAgICAgICAgIH0NCj4g
PiANCj4gPiAtICAgICAgICAgICAgICAgYnVmID0gcGFnZV9mcmFnX2FsbG9jKCZxLT5yeF9wYWdl
LCBxLT5idWZfc2l6ZSwNCj4gPiBHRlBfQVRPTUlDKTsNCj4gPiAtICAgICAgICAgICAgICAgaWYg
KCFidWYpDQo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7DQo+ID4gKyAgICAgICAg
ICAgICAgIGlmICghc2tpcF9hbGxvYykgew0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGJ1
ZiA9IHBhZ2VfZnJhZ19hbGxvYygmcS0+cnhfcGFnZSwgcS0NCj4gPiA+YnVmX3NpemUsDQo+ID4g
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdGUF9BVE9NSUMp
Ow0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGlmICghYnVmKQ0KPiA+ICsgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgYnJlYWs7DQo+ID4gKyAgICAgICAgICAgICAgIH0NCj4gPiAN
Cj4gPiAgICAgICAgICAgICAgICAgYWRkciA9IGRtYV9tYXBfc2luZ2xlKGRldi0+ZG1hX2Rldiwg
YnVmLCBsZW4sDQo+ID4gRE1BX0ZST01fREVWSUNFKTsNCj4gPiAgICAgICAgICAgICAgICAgaWYg
KHVubGlrZWx5KGRtYV9tYXBwaW5nX2Vycm9yKGRldi0+ZG1hX2RldiwNCj4gPiBhZGRyKSkpIHsN
Cj4gPiAtLQ0KPiA+IDIuMTguMA0KPiA+IA0KPiA+ID4gPiAtLSANCj4gPiA+ID4gMi4xOC4wDQo+
ID4gPiA+IA0K