Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp6110298rwj; Wed, 21 Dec 2022 10:52:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXtQ1ySYgJgxfua3yBZ9bZQ9x4x4FVaJ8MZejpBAf9xuk1CjZZMJceEr3sEsHzk0sidri2b2 X-Received: by 2002:a05:6a20:3c93:b0:9d:efbe:a113 with SMTP id b19-20020a056a203c9300b0009defbea113mr4174720pzj.35.1671648732474; Wed, 21 Dec 2022 10:52:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671648732; cv=none; d=google.com; s=arc-20160816; b=k2n/vdHcOH/l63al9EfNCsQwrcaOZwdSrneFnYhX5xGjEF7aEqF5JmcOCYGMT4WrMW DS7ZOfwx8h9wtVfEam3UHZsvdqvoZOngErAoytHzbyoRSE+3sxfm21ncnUjixXGrySPm 1pNtDfhuNBOsWlwPVS5ej7dLLw8XuWHmnyqsdh21TluYmdexVPEy4v9fwWG0n0QRbiJ/ 5qYw0oQQMlSNkyIvf6xJeUpl3fQdaszw94rv//qxpd2odSp2ZG72txwj4po2N3ugf8Nl p/6byLAXm+lFfRM6qCG++UDIMxcK9gA0XfnlVM/QWOSq78jmAi1ic6L7evTmJBG+D58N yQDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=/Asx5ODict/74drs2jx60cG5EjuiGladu0g6Fczk4fU=; b=aPJRfR0x8BGSkjlMcz6IMDywOa1Xmam83rmkSjJilqdUftOFrDzOgW9RC0ymF1iNXv aWuW55tciYnyq+Dkq0Ny3oYM80tVS4xUcrzxSzAQ1iSLnZxd7n4hPEmx+jqbiR96wuC3 Rc0Il6Lub31tCPx5f38sS3hmm6WryFfk0ttrMXPmY9g1OruBdGhAvec0n+4Zbx3/zAZ4 oZ9y9IwbxN7J0A47WKXTsrrlRcEzHIO4YdCd6+PLu0Xs4FXOKduc4CbPUHMi5VfIUMxX KWis754bz5GNSxoyBHTsawdvdYVjlNzxQ9tduBAhQKVyRJcytbyO9EpGvqm6WdV+dgF7 182Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MdGhzGIE; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x70-20020a638649000000b0047947d45f57si147976pgd.745.2022.12.21.10.52.04; Wed, 21 Dec 2022 10:52:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MdGhzGIE; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234980AbiLUSwC (ORCPT + 66 others); Wed, 21 Dec 2022 13:52:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234992AbiLUSwA (ORCPT ); Wed, 21 Dec 2022 13:52:00 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98912D4 for ; Wed, 21 Dec 2022 10:51:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3321E618EF for ; Wed, 21 Dec 2022 18:51:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49CE6C433F0; Wed, 21 Dec 2022 18:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671648718; bh=KVa/AvlxRDVGEqClLcCqRj4GriYElnaUainJpFpPUa8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=MdGhzGIEUwwRXj6ZpWpJGyH6wymDM+n6Ne/tVQRvdrDCtmFZ7T34h6TwDrQOo+FEZ +Ts0zp829LM0AjWmpJZ0IV1aK0GV6zqf9Nkk8pBSEMB9xYiim4hyrQDxOgLIpfej61 xirv8z2Jvzv6zjMar6K4HAeGfTJPbyFjGUkLbhO00qYsGh+ZiUQBqTaUN+8vbgHGZw KT9UpRCA1uMg1qCyejs70/2pAqs5kFfsyQwL9RQjk2/yKhn2MKVj+trXDXulyjF6FI Mw2ndbL0ZIgy4wOh45eBcNEOr5+/Vqkq5FRJO/O7Cv+zO06rb6vFIfKooJgqmuDmaY l/yO0///ZWAMg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3 1/5] wifi: rtl8xxxu: Deduplicate the efuse dumping code From: Kalle Valo In-Reply-To: <2aa5200a-ee42-e064-16a1-672bed5708c6@gmail.com> References: <2aa5200a-ee42-e064-16a1-672bed5708c6@gmail.com> To: Bitterblue Smith Cc: "linux-wireless@vger.kernel.org" , Jes Sorensen , Ping-Ke Shih , Andrea Merello , Taehee Yoo User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167164871560.5196.478659665415497087.kvalo@kernel.org> Date: Wed, 21 Dec 2022 18:51:57 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Bitterblue Smith wrote: > Every chip family except RTL8723AU has a copy of the efuse dumping > code. Remove this and dump the efuse from a single place using a new > function rtl8xxxu_dump_efuse(). > > Also, use print_hex_dump() to print the efuse instead of a loop and > dev_info(). It shows the ASCII interpretation of the bytes, which is > nice. > > Signed-off-by: Bitterblue Smith > Reviewed-by: Ping-Ke Shih 5 patches applied to wireless-next.git, thanks. 4f198e720eab wifi: rtl8xxxu: Deduplicate the efuse dumping code d7a3705c9634 wifi: rtl8xxxu: Make rtl8xxxu_load_firmware take const char* b75289e89459 wifi: rtl8xxxu: Define masks for cck_agc_rpt bits 3dfb8e844fa3 wifi: rtl8xxxu: Support new chip RTL8188EU 8b9754b28f0f wifi: rtl8xxxu: Add rate control code for RTL8188EU -- https://patchwork.kernel.org/project/linux-wireless/patch/2aa5200a-ee42-e064-16a1-672bed5708c6@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches