Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] ath11k: update debugfs support for mupltiple radios in
 PCI
 bus
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <1614160542-27882-1-git-send-email-akolli@codeaurora.org>
References: <1614160542-27882-1-git-send-email-akolli@codeaurora.org>
To:     Anilkumar Kolli <akolli@codeaurora.org>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
        Anilkumar Kolli <akolli@codeaurora.org>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <167172289467.8231.1004330123245787946.kvalo@kernel.org>
Date:   Thu, 22 Dec 2022 15:28:18 +0000 (UTC)
Precedence: bulk

Anilkumar Kolli <akolli@codeaurora.org> wrote:

> debugfs_ath11k struct is moved to ath11k_core, since its common
> for both pci and ahb.
> 
> Current ath11k_pci insmod fails if there are multiple PCI rdaios,
> 
>  ath11k_pci 0000:01:00.0: Hardware name qcn9074 hw1.0
>  debugfs: Directory 'ath11k' with parent '/' already present!
>  ath11k_pci 0000:01:00.0: failed to create ath11k debugfs
>  ath11k_pci 0000:01:00.0: failed to create soc core: -17
>  ath11k_pci 0000:01:00.0: failed to init core: -17
>  ath11k_pci: probe of 0000:01:00.0 failed with error -17
> 
> To avoid the failure, debugfs directory is created with soc_name
> and bus_id to allow creating debugfs directory for second PCI radio.
> 
> with this Debugfs entries looks like,
>  # ls -l /sys/kernel/debug/ath11k/
>  ipq8074 hw2.0 qcn9000 hw1.0_0000:01:00.0 qcn9000 hw1.0_0001:01:00.0
> 
>  # ls -l /sys/kernel/debug/ath11k/ipq8074 hw2.0/
>   mac0  mac1 simulate_fw_crash soc_dp_stats
> 
>  # ls -l /sys/kernel/debug/ath11k/qcn9000 hw1.0_0000:01:00.0
>   mac0 simulate_fw_crash soc_dp_stats
> 
>  # /sys/kernel/debug/ath11k/qcn9000 hw1.0_0001:01:00.0:
>    mac0  simulate_fw_crash soc_dp_stats
> 
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1.r2-00012-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>

I submitted my version here:

https://patchwork.kernel.org/project/linux-wireless/patch/20221220121231.20120-1-kvalo@kernel.org/

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1614160542-27882-1-git-send-email-akolli@codeaurora.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches