Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [wireless] wifi: wilc1000: add missing unregister_netdev() in
 wilc_netdev_ifc_init()
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <1669289902-23639-1-git-send-email-wangyufen@huawei.com>
References: <1669289902-23639-1-git-send-email-wangyufen@huawei.com>
To:     Wang Yufen <wangyufen@huawei.com>
Cc:     <ajay.kathat@microchip.com>, <claudiu.beznea@microchip.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <davidm@egauge.net>, <wangyufen@huawei.com>,
        <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <167172519205.8231.13844478076238489383.kvalo@kernel.org>
Date:   Thu, 22 Dec 2022 16:06:33 +0000 (UTC)
Precedence: bulk

Wang Yufen <wangyufen@huawei.com> wrote:

> Fault injection test reports this issue:
> 
> kernel BUG at net/core/dev.c:10731!
> invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI
> Call Trace:
>   <TASK>
>   wilc_netdev_ifc_init+0x19f/0x220 [wilc1000 884bf126e9e98af6a708f266a8dffd53f99e4bf5]
>   wilc_cfg80211_init+0x30c/0x380 [wilc1000 884bf126e9e98af6a708f266a8dffd53f99e4bf5]
>   wilc_bus_probe+0xad/0x2b0 [wilc1000_spi 1520a7539b6589cc6cde2ae826a523a33f8bacff]
>   spi_probe+0xe4/0x140
>   really_probe+0x17e/0x3f0
>   __driver_probe_device+0xe3/0x170
>   driver_probe_device+0x49/0x120
> 
> The root case here is alloc_ordered_workqueue() fails, but
> cfg80211_unregister_netdevice() or unregister_netdev() not be called in
> error handling path. To fix add unregister_netdev goto lable to add the
> unregister operation in error handling path.
> 
> Fixes: 09ed8bfc5215 ("wilc1000: Rename workqueue from "WILC_wq" to "NETDEV-wq"")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>

Patch applied to wireless-next.git, thanks.

2b88974ecb35 wifi: wilc1000: add missing unregister_netdev() in wilc_netdev_ifc_init()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1669289902-23639-1-git-send-email-wangyufen@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches