Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp320854rwj; Thu, 22 Dec 2022 08:08:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXs/zPUjvKDtgOmkPmLfceDn3vLV7Q1Hw2sNeqC5PvpeaQdDdO4GhtGnez5NvkAg6ei5/1Pg X-Received: by 2002:a05:6a20:9585:b0:af:dbe9:4466 with SMTP id iu5-20020a056a20958500b000afdbe94466mr8117111pzb.31.1671725320858; Thu, 22 Dec 2022 08:08:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671725320; cv=none; d=google.com; s=arc-20160816; b=b+ocZ6HjmrAo4qMy0ZnexxBJGpGP4Bxyf4Are4jt3H6DHMGWzNDyM56ECx7+p8B1XM RbE000IMBwHID1zm56rDMsJuZuJGshH+mGIYuo6M+UjkCcfHJyLBfrFiSdD2OIeWZlYm 667kr6IeUVVdza6HlD0saxRH8kVVppzYwiqIg/6ToN11RAi35/haUldOJTzty+/9uh6R HSlnmz0/JY02+yx/9qsJ3kKtuQg+b6WaOsshRiRJZdsjt+aQKHzKFA2zDqkL1Py86Yov 7mN2372aPmKjpEJxDuza18lU+gPs7v39ohe74jLzPGnxcHWizHawyUaYAo8LlYR+eQi9 uycw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=nH+tPARSUHp336e96zkfqkwuUq9hwSQpCfFy7Wk1H9E=; b=mxCuiPC4Er3YJkzxOqATbU6nYZhs0ei+/EoQsiGc5bJVoo0/MJ73bnp0/yuXK3BgTJ okZS3K1TOyrxqnnBgfnWLfmpdLWjkGdi+siQmhOCPXPsHTxJTeB/aTAAI+zZO2NaaBWz 6M/zXGY7aWvsvXbAB9CAASMuAFgO3eMZ3PnOhE3914PsonZQFNCzUcatdxYsobra6IKf HBNvSfZy9yhNiwrcnSajdThSLk3XFlDLkrxTg29R9aFRwjRqHmOOdPZVRl91kSKeSuOj VCX/NLLW7MMLAUxpunZDtvHRGujiulSMwIcSdRTmcfg010UJwCK08zAcTWrcbQmoLhFy nnVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kZp+YfHM; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bc25-20020a656d99000000b0047699804989si1107951pgb.64.2022.12.22.08.08.32; Thu, 22 Dec 2022 08:08:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kZp+YfHM; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229734AbiLVQGO (ORCPT + 66 others); Thu, 22 Dec 2022 11:06:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230329AbiLVQGL (ORCPT ); Thu, 22 Dec 2022 11:06:11 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1CAE1E3EE; Thu, 22 Dec 2022 08:06:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9B893B81AFD; Thu, 22 Dec 2022 16:06:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1247BC433D2; Thu, 22 Dec 2022 16:06:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671725168; bh=yH5TY+BXIUX/RtGMIoGIZ/+GUrwkUycltBr89jfW6OA=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=kZp+YfHMr6wiksQT7I204ywCiQ/ZCYyxBt3oQQsE3m4NctAR1KyfeXd0bD1pXcSMs +qOLhFqfhF1VMxRECQ+omYiuj12lydKmKyepy6hkw84uobOuYAErczthwW4KvD868i fO6IDDIe4DQ2bpC88iWDHPLw2PLxXqHOW2faAspKG6t2HH5cP/xkpKBiiS2+q3OCjA SSPebE58UWcvwt1XcCHG0953ukMg9GhZOCenSGxHct9S3DrE4UBuy7E2X+Zwtyq+eJ F7XBzh/oMP63MIPEL7MgurQhO8+kzUkoNTvLeo5HakCDdyHLVfKk2QsIMbpOIX6nMK U/WNxYG/bmNPQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [wireless,v2] wifi: wilc1000: fix potential memory leak in wilc_mac_xmit() From: Kalle Valo In-Reply-To: <1668684964-48622-1-git-send-email-zhangchangzhong@huawei.com> References: <1668684964-48622-1-git-send-email-zhangchangzhong@huawei.com> To: Zhang Changzhong Cc: Ajay Singh , Claudiu Beznea , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Johnny Kim , Greg Kroah-Hartman , Chris Park , Rachel Kim , "Nicolas Ferre" , Zhang Changzhong , , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167172516319.8231.9400853979965474557.kvalo@kernel.org> Date: Thu, 22 Dec 2022 16:06:04 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Zhang Changzhong wrote: > The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add > dev_kfree_skb() to fix it. Compile tested only. > > Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") > Signed-off-by: Zhang Changzhong Patch applied to wireless-next.git, thanks. deb962ec9e1c wifi: wilc1000: fix potential memory leak in wilc_mac_xmit() -- https://patchwork.kernel.org/project/linux-wireless/patch/1668684964-48622-1-git-send-email-zhangchangzhong@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches