Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp349183rwj; Thu, 22 Dec 2022 08:28:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXsqTbzcEcwbCU+rvFJ9km5xmiuZZq/U8obg/mYF614PcJ1JhX9MWVKqmRmTcoHT7B7ZmatH X-Received: by 2002:a05:6402:1654:b0:461:78ef:56f2 with SMTP id s20-20020a056402165400b0046178ef56f2mr5233523edx.34.1671726516233; Thu, 22 Dec 2022 08:28:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671726516; cv=none; d=google.com; s=arc-20160816; b=YkjUk5kS4fmriM/l2XN/Whvk+NbQNCy7LtsgIAn1vENSbM7kSg11l64I//NhzKCW4m sQNMFePvHcXxurMsyurOdyetqTgdu/pYZcq/l8vDWGn+3mUeRh89QR/qweghkWGws/WT F29E0B+Fu9FVcIbFneQXSS5WYFh2fYbhoDVJt9186JKL+dL0EqAL7WqcyhI01oCxJXmI bPRIpZzICC0nD28vcz+XR4O2LM9+wVf/jz7ZvEoDnrBnmYW8lt2fAaf/LS3cOvwvgB9H hR8M9NJP21nK3xGbyQoVR76E8IBbj1ppyZl136c6vhq4Nt1pJT/QlWu2FA3q/BGC0BYA 7Z4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=DNXrgsdC/C18dE4yG1H7v/dWYafKAJai8zyR7j+zM54=; b=JALadvm+tsWs21RmDFx++TrgFMM3AeJQS8/NF6GBfuBFgNvaiLv3xJjZ5QafOsyktV nYT/5VsblwQaWW1nXI/rYv5uNmIu3sVIXBq9mX47MxKWpyPFnVGzZFE/f+8KHtf4LROV sUO+q5+ml/L63vr6vea6GTZxI4jnVRwrYPmtLo9TGVrcbbScUfAGuqxKPVqQ7y1fwOPp H311IgWo24oFnoKUp2O7n75CoIgN+NSG25PMg9sFvt+qhycJW1DzN95dGO0DKf+3zRQf 8vKY74tUaHkZz4Tu1Vue6wBTjRFhgNErg74fPbMnDECmaS2hFOvTcd/muf65cvZF76hU mY0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="huV/1uhk"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dz8-20020a0564021d4800b0046b998ac55bsi1126691edb.575.2022.12.22.08.28.19; Thu, 22 Dec 2022 08:28:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="huV/1uhk"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235149AbiLVQSA (ORCPT + 66 others); Thu, 22 Dec 2022 11:18:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbiLVQR6 (ORCPT ); Thu, 22 Dec 2022 11:17:58 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EE212228B for ; Thu, 22 Dec 2022 08:17:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4E774B802C7 for ; Thu, 22 Dec 2022 16:17:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34CAAC433D2; Thu, 22 Dec 2022 16:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671725874; bh=QCms9H0ToEeePecTBPF4EKUW5Q9CaBl7VGTx7ekYma4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=huV/1uhkGEQ8foO5E1lozmmgDihohsXFNLUgEF52tgoJ5IYTr8GrSk/yi7fXrMsJ/ bKgfSB60vRKdX4MnMLbUOPw/H32hl4xLibz3oU+BVqvrMO1NMap4BD3O3Lk9lsX/Rd JMK/RQLpDT1wWOcA36FlH1TaCxu/P2KLFLnVN4Qs9tlu+cJLkGLGjWjh4X4jz/lnq/ Gt/FndB3ZfVQIeuj0624euJkrx0uVrn5txhwtsFXm9HpFNub8GgfGiyim2pQGIJ3W1 WlZGTAifGuBXm82rF8xJZ/TzV1Q5kiYaNKBww2RUqpblT62FtYbni9C2HVXYdKs3Zg NVwmNqJKr8GiA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v2] wifi: wl3501_cs: don't call kfree_skb() under spin_lock_irqsave() From: Kalle Valo In-Reply-To: <20221207150453.114742-1-yangyingliang@huawei.com> References: <20221207150453.114742-1-yangyingliang@huawei.com> To: Yang Yingliang Cc: , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <167172587248.8231.1000881782979758530.kvalo@kernel.org> Date: Thu, 22 Dec 2022 16:17:54 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Yang Yingliang wrote: > It is not allowed to call kfree_skb() from hardware interrupt > context or with interrupts being disabled. So replace kfree_skb() > with dev_kfree_skb_irq() under spin_lock_irqsave(). Compile > tested only. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Yang Yingliang Patch applied to wireless-next.git, thanks. 44bacbdf9066 wifi: wl3501_cs: don't call kfree_skb() under spin_lock_irqsave() -- https://patchwork.kernel.org/project/linux-wireless/patch/20221207150453.114742-1-yangyingliang@huawei.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches