Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp717552rwj; Fri, 23 Dec 2022 07:15:15 -0800 (PST) X-Google-Smtp-Source: AMrXdXvR7J9H9lBY+UpigR7Knc/aFwTnqkeQ2Zar9l+bvH4arHcfqJY+SvhOngePSr0YQpDdul3F X-Received: by 2002:a17:907:7da4:b0:78d:f455:b5dc with SMTP id oz36-20020a1709077da400b0078df455b5dcmr9454373ejc.28.1671808515351; Fri, 23 Dec 2022 07:15:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671808515; cv=none; d=google.com; s=arc-20160816; b=wnEsjHC+BuPWizf8EKurVKiluX1YGE7HfghEx88mcIKOv4mCGk0KOrrp33tLoJaSnz uPAys692qeqK1Dh7QLFy0P47daeB7Ht7SPdnZJyu2E2LwvMwjuKOvYdehXvsG7ez6l0b 78uolfBJ1h1ZityHcDhkRlWn5dz59ov7s9hqfYP0KK6XBBddwbu1PjihoMJJRYJZcS/R KwQPyyofp/iBNxQvohJNdFJVlgn7L6yJPq2oLvP3FcYblNBMgoNu0+qQ1Kbi3qymQ5qL mEBPqpzx8g0Xc59Xu37L0ioVdzyRwyeh5JJWiLQZC8gN7UkALaON3kyDPraeEZTYzW7q BlcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=taJ0i+7Nxx5EGMviFuL0glHUCiE6Cqkuar1xYPtimWg=; b=LdwJPFSK0T0+lmhrebEFjOQI9aFi6DehERDoKCC7ZqcgsamdUKE+JdUN8OxiWA6B8S 6GQApp3f0uRnddeUnO56VO1mCT4SgfSPQaoQygO5eggtcjGwQ9m0k3BYWoBvAKqOctim BbZnYruO3kASoQ+faURkx3TiqAFbhcWmJT9w45azHq13jNWcR8540EnLic6SyEHAmvR+ rUHxCSR1TF7G/7M7QkS0lngHEfjdVsF8s/eYjw6YRgYrGQdR4nSmH5/N33eF2kBebVxi tv8b2MBaJPr6x9MNJRqVu0I1zxrDXutD1jhKW4LRWQk/HsxvXG7P7ScllpttJpyhedaV 1f3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=eu5UtAuX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id js3-20020a17090797c300b007bd112b2764si2805073ejc.381.2022.12.23.07.14.55; Fri, 23 Dec 2022 07:15:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=eu5UtAuX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236430AbiLWPDF (ORCPT + 66 others); Fri, 23 Dec 2022 10:03:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236265AbiLWPDC (ORCPT ); Fri, 23 Dec 2022 10:03:02 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3787024BE0; Fri, 23 Dec 2022 07:03:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=taJ0i+7Nxx5EGMviFuL0glHUCiE6Cqkuar1xYPtimWg=; b=eu5UtAuXqQnUtZet6ohjMxkRpj 2YyT7RAghaQAMTQy2NS6BNaIMxRK2e4Bll3mcM1weeC+Mv5CwfnvMxPxn2od+wlrLs56EjBjlKiVe pm5MwN0AexAFClgGmgb0s32Mrar687d4FANiQr21kvlzD2c3vUP7N4DLDXSW396w/NLRll0G+BRl5 IVUjREi4cSxMhN/8hGC9QTRnSSS7CGuFEFVmXMwBrrooTlxHW4WqCUIUyQtJVty9Il4hGdV/V1J10 vgkV7IlJaD3C7H+v5ty/NbJHa+d+JE+YMGcRZrbUfZja3VnayhHeAkgiq4vvumUeTe4j9Dagmx9xA DAsA0DRA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8jZV-009ADo-MI; Fri, 23 Dec 2022 15:02:53 +0000 Date: Fri, 23 Dec 2022 07:02:53 -0800 From: Luis Chamberlain To: yang.yang29@zte.com.cn Cc: jirislaby@kernel.org, mickflemm@gmail.com, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xu.panda@zte.com.cn Subject: Re: [PATCH net-next] ath5k: use strscpy() to instead of strncpy() Message-ID: References: <202212231034450492161@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202212231034450492161@zte.com.cn> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, Dec 23, 2022 at 10:34:45AM +0800, yang.yang29@zte.com.cn wrote: > From: Xu Panda > > The implementation of strscpy() is more robust and safer. > That's now the recommended way to copy NUL-terminated strings. According to who? Are you sure you are not just sending stupid commits to get an increase in your kernel commit count? Because this is an old driver and who cares? Luis