Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Dec 2022 10:03:56 -0600
From:   sforshee <sforshee@kernel.org>
To:     kleo <kleo@hak.dog>
Cc:     wireless-regdb <wireless-regdb@lists.infradead.org>,
        linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: wireless-regdb: Update regulatory rules for Philippines (PH)
Message-ID: <Y6XRbJThM4oKMOVY@ubuntu-x1>
References: <184ec3a63fe.d96b82f6427171.7593361304891506395@hak.dog>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <184ec3a63fe.d96b82f6427171.7593361304891506395@hak.dog>
Precedence: bulk

Sorry for the slow response. Please see my responses below.

In addition to those comments, the patch isn't formatted correctly for
application, and it is missing a Signed-off-by tag as noted in the
CONTRIBUTING file. For sending your patch I suggest using 'git
format-patch' to export the patch to a file and then either using 'git
send-email' to send it as an email or attaching the patch to your email
message.

On Wed, Dec 07, 2022 at 06:56:00PM +0800, kleo wrote:
> diff --git a/db.txt b/db.txt
> index 3f74194..fa9ffd7 100644
> --- a/db.txt
> +++ b/db.txt
> @@ -1368,11 +1368,17 @@ country PG: DFS-FCC
>         (5735 - 5835 @ 80), (30)
>  
>  country PH: DFS-FCC
> -       (2402 - 2482 @ 40), (20)
> -       (5170 - 5250 @ 80), (17), AUTO-BW
> -       (5250 - 5330 @ 80), (24), DFS, AUTO-BW
> -       (5490 - 5730 @ 160), (24), DFS
> -       (5735 - 5835 @ 80), (30)
> +       # https://ntc.gov.ph/wp-content/uploads/2015/10/LawsRulesRegulations/MemoCirculars/MC2003/MC-09-09-2003.pdf
> +       # https://ntc.gov.ph/wp-content/uploads/2015/10/LawsRulesRegulations/MemoCirculars/MC2013/MC-03-08-2013.pdf
> +       # https://ntc.gov.ph/wp-content/uploads/2016/MC/Explanatory-MC-No-01-01-2016.pdf
> +       # https://ntc.gov.ph/wp-content/uploads/2022/mc/Memorandum_Cicurlar_No._002-09-2021.pdf

The documents you linked to establish use of the frequency bands but
don't seem to contain any information about the relevant power limits
and other requirements. Where did this information come from?

> +       (915 - 918 @ 2), (30)

I don't see anything in the above documents about the 915-918 MHz band.
I also don't see that range listed in this table of frequency
allocations that I found:

https://ntc.gov.ph/wp-content/uploads/2022/frequencyallocations/NRFAT_Rev_2020.pdf

What's the basis for allowing this range?

Thanks,
Seth

> +       (2400 - 2483.5 @ 40), (24)
> +       (5150 - 5250 @ 80), (24), AUTO-BW
> +       (5250 - 5350 @ 80), (24), DFS, AUTO-BW
> +       (5470 - 5730 @ 160), (24), DFS
> +       (5730 - 5850 @ 80), (30)
> +       (57000 - 66000 @ 2160), (40)
>  
>  country PK: DFS-JP
>         # https://fab.gov.pk/type-approval/
> 
> c5da72a2fef48891aceb3f3378afbb12a2778c83e9f053f5d23e589630536b61  country-ph.patch
> 
> kleo
> 
> 
>