Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <35c73172-4e06-3877-56bd-133f9192adc3@leemhuis.info>
Date:   Mon, 26 Dec 2022 11:59:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [6.2][regression] after commit
 cd372b8c99c5a5cf6a464acebb7e4a79af7ec8ae stopping working wifi mt7921e
From:   Thorsten Leemhuis <regressions@leemhuis.info>
To:     Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
        Felix Fietkau <nbd@nbd.name>
Cc:     lorenzo@kernel.org, sujuan.chen@mediatek.com,
        Linux List Kernel Mailing <linux-wireless@vger.kernel.org>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
References: <CABXGCsMEnQd=gYKTd1knRsWuxCb=Etv5nAre+XJS_s5FgVteYA@mail.gmail.com>
 <678adc67-9e46-3eef-f274-c951b121570f@nbd.name>
 <CABXGCsMUbs+bf=tWnx98r4v_JzVmYdVyOos9EhcGJ6jnEwathA@mail.gmail.com>
 <a30d8580-936a-79e4-c1c7-70f3d3b8da35@nbd.name>
 <CABXGCsNJKy2SQffeU+uaua5SM_77YiGKdPLRdzSF3F+ShpF+5w@mail.gmail.com>
 <3cb53fbd-0bee-22f9-bba2-6ac4a87db521@nbd.name>
 <CABXGCsOarWTb9+ofcd14bLGuWEQOTqRQQ0bXP57mhVjnpjcEQQ@mail.gmail.com>
 <69ccf9f3-ce2e-600d-00b3-51ccc4a73011@leemhuis.info>
Content-Language: en-US, de-DE
In-Reply-To: <69ccf9f3-ce2e-600d-00b3-51ccc4a73011@leemhuis.info>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 24.12.22 08:55, Thorsten Leemhuis wrote:
> 
> 
> On 22.12.22 07:47, Mikhail Gavrilov wrote:
>> On Wed, Dec 21, 2022 at 10:17 PM Felix Fietkau <nbd@nbd.name> wrote:
>>>
>>> Sorry, I worked on a tree that had other pending fixes applied.
>>> Please try this:
>>>
>>>
>>> --- a/drivers/net/wireless/mediatek/mt76/dma.c
>>> +++ b/drivers/net/wireless/mediatek/mt76/dma.c
>>> @@ -205,6 +205,52 @@ mt76_dma_queue_reset(struct mt76_dev *dev, struct mt76_queue *q)
>>>         mt76_dma_sync_idx(dev, q);
>>>   }
>> [cutted]
>>>   EXPORT_SYMBOL_GPL(mt76_rx_token_consume);
>>>
>>
>> I confirms after applying this patch the issue was gone (wifi works as
>> before commit cd372b8c99c5a5cf6a464acebb7e4a79af7ec8ae).
>>
>> Tested-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
>>
> 
> TWIMC, there are two more reports that at least to my eyes look like
> they are about the problem discussed here:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=216829

Stupid me, this one...

> https://bugzilla.kernel.org/show_bug.cgi?id=216839

...is about 6.1.y and thus likely something else. Apologies.

FWIW & for completeness, according to a comment from Lorenzo Bianconi
the latter bug report is fixed by:
https://patchwork.kernel.org/project/linux-wireless/patch/20221217085624.52077-1-nbd@nbd.name/
("wifi: mac80211: fix initialization of rx->link and rx->link_sta")

Ciao, Thorsten