Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221206114609.2006175-1-yangyingliang@huawei.com> <20221206114609.2006175-5-yangyingliang@huawei.com>
In-Reply-To: <20221206114609.2006175-5-yangyingliang@huawei.com>
From:   Info Skymem <info@skymem.com>
Date:   Thu, 29 Dec 2022 04:18:25 +0100
Message-ID: <CAKvd=_ikEBFk080XoegEzH-JNM6ZuCLMzGL2ZqRzxyVLJCX9-Q@mail.gmail.com>
Subject: Re: [PATCH 4/4] libertas: don't call kfree_skb() under
 spin_lock_irqsave() in lbs_mac_event_disconnected()
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     kvalo@kernel.org, libertas-dev@lists.infradead.org,
        linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,
thank you for your information.

On our website you can find email addresses of companies and people.
https://www.skymem.info

In short, it=E2=80=99s like Google for emails.

Best regards,
Robert,
Skymem team

On Tue, Dec 6, 2022 at 12:49 PM Yang Yingliang <yangyingliang@huawei.com> w=
rote:
>
> It is not allowed to call kfree_skb() from hardware interrupt
> context or with interrupts being disabled. So replace kfree_skb()
> with dev_kfree_skb_irq() under spin_lock_irqsave().
>
> Fixes: f52b041aed77 ("libertas: Add spinlock to avoid race condition")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/net/wireless/marvell/libertas/cmdresp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas/cmdresp.c b/drivers/ne=
t/wireless/marvell/libertas/cmdresp.c
> index cb515c5584c1..74cb7551f427 100644
> --- a/drivers/net/wireless/marvell/libertas/cmdresp.c
> +++ b/drivers/net/wireless/marvell/libertas/cmdresp.c
> @@ -48,7 +48,7 @@ void lbs_mac_event_disconnected(struct lbs_private *pri=
v,
>
>         /* Free Tx and Rx packets */
>         spin_lock_irqsave(&priv->driver_lock, flags);
> -       kfree_skb(priv->currenttxskb);
> +       dev_kfree_skb_irq(priv->currenttxskb);
>         priv->currenttxskb =3D NULL;
>         priv->tx_pending_len =3D 0;
>         spin_unlock_irqrestore(&priv->driver_lock, flags);
> --
> 2.25.1
>
>
> _______________________________________________
> libertas-dev mailing list
> libertas-dev@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/libertas-dev