Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221206114609.2006175-1-yangyingliang@huawei.com> <20221206114609.2006175-4-yangyingliang@huawei.com>
In-Reply-To: <20221206114609.2006175-4-yangyingliang@huawei.com>
From:   Info Skymem <info@skymem.com>
Date:   Thu, 29 Dec 2022 04:18:31 +0100
Message-ID: <CAKvd=_iVE6nocALPEw8hzTZMm6rAv5PmnBkFiVZ_D-AjRNQeNA@mail.gmail.com>
Subject: Re: [PATCH 3/4] libertas: don't call kfree_skb() under
 spin_lock_irqsave() in lbs_stop_iface()
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     kvalo@kernel.org, libertas-dev@lists.infradead.org,
        linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,
thank you for your information.

On our website you can find email addresses of companies and people.
https://www.skymem.info

In short, it=E2=80=99s like Google for emails.

Best regards,
Robert,
Skymem team

On Tue, Dec 6, 2022 at 12:49 PM Yang Yingliang <yangyingliang@huawei.com> w=
rote:
>
> It is not allowed to call kfree_skb() from hardware interrupt
> context or with interrupts being disabled. So replace kfree_skb()
> with dev_kfree_skb_irq() under spin_lock_irqsave().
>
> Fixes: d2e7b3425c47 ("libertas: disable functionality when interface is d=
own")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/net/wireless/marvell/libertas/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas/main.c b/drivers/net/w=
ireless/marvell/libertas/main.c
> index 8f5220cee112..f42d28d99763 100644
> --- a/drivers/net/wireless/marvell/libertas/main.c
> +++ b/drivers/net/wireless/marvell/libertas/main.c
> @@ -216,7 +216,7 @@ int lbs_stop_iface(struct lbs_private *priv)
>
>         spin_lock_irqsave(&priv->driver_lock, flags);
>         priv->iface_running =3D false;
> -       kfree_skb(priv->currenttxskb);
> +       dev_kfree_skb_irq(priv->currenttxskb);
>         priv->currenttxskb =3D NULL;
>         priv->tx_pending_len =3D 0;
>         spin_unlock_irqrestore(&priv->driver_lock, flags);
> --
> 2.25.1
>
>
> _______________________________________________
> libertas-dev mailing list
> libertas-dev@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/libertas-dev