Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221229124845.1155429-1-martin.blumenstingl@googlemail.com> <d09d2480-a21e-69b3-90e4-5f361947057b@lwfinger.net>
In-Reply-To: <d09d2480-a21e-69b3-90e4-5f361947057b@lwfinger.net>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Thu, 29 Dec 2022 21:11:43 +0100
Message-ID: <CAFBinCBYbmrxP7UegAO7n7d1Dd=xo4pG1RE=H5-NVoSRX=Vdvg@mail.gmail.com>
Subject: Re: [PATCH 0/4] rtw88: Four fixes found while working on SDIO support
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     linux-wireless@vger.kernel.org, tony0620emma@gmail.com,
        kvalo@kernel.org, pkshih@realtek.com, s.hauer@pengutronix.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello Larry,

On Thu, Dec 29, 2022 at 6:41 PM Larry Finger <Larry.Finger@lwfinger.net> wrote:
[...]
> I do not feel qualified to review these contributions, but I have some suggestions.
>
> The first is that the subject should start with wifi: rtw88: .... That is a
> fairly recent change that you likely did not catch.
Oh, this is something that I missed. I'll wait until tomorrow to see
if I can get Ping-Ke's Reviewed-by on patch 1 and then re-send the
whole series with fixed subjects.

> My second comment is that changed patches should have a version number to
> identify that they are new patches.
This series had four patches from the beginning. So no patches were
added/removed during the lifecycle of this patchset.
I think the cover-letter subject is a bit misleading as it contains
the words "SDIO support". In fact the issues (which are fixed by this
series) were found while working on SDIO support, but they also apply
to existing PCIe/USB support.

> [...] Once you have generated the patches, you
> should then edit them to indicate what change was made to each patch in the
> various versions. Such explanations should go below the --- following the
> Signed-off-by line, and end with another ---. With these additions, the
> community, and more importantly Kalle, can keep track of the various versions,
> and know what reviewer's comments have been addressed.
Noted. I will take care of this in v3 along with the updated subjects.

> I know of several people that have asked about SDIO versions of these drivers.
> They will be pleased to see them become available.
Thanks for the motivating words :-)


Best regards,
Martin