Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4d3afaf9-1511-5eb0-0c84-7897c0beca4e@leemhuis.info>
Date:   Mon, 2 Jan 2023 09:09:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v5] wifi: mac80211: fix initialization of rx->link and
 rx->link_sta
Content-Language: en-US, de-DE
To:     Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Cc:     johannes@sipsolutions.net, quic_srirrama@quicinc.com,
        "regressions@lists.linux.dev" <regressions@lists.linux.dev>
References: <20221230200747.19040-1-nbd@nbd.name>
From:   Thorsten Leemhuis <regressions@leemhuis.info>
In-Reply-To: <20221230200747.19040-1-nbd@nbd.name>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi, this is your Linux kernel regression tracker.

On 30.12.22 21:07, Felix Fietkau wrote:
> There are some codepaths that do not initialize rx->link_sta properly. This
> causes a crash in places which assume that rx->link_sta is valid if rx->sta
> is valid.
> One known instance is triggered by __ieee80211_rx_h_amsdu being called from
> fast-rx. It results in a crash like this one:

Many thx for working on this.

> [...]
> Fixes: ccdde7c74ffd ("wifi: mac80211: properly implement MLO key handling")
> Fixes: b320d6c456ff ("wifi: mac80211: use correct rx link_sta instead of default")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>

Shouldn't this have a Cc: stable@vger.kernel.org to ensure it's
backported (no, Fixes: tags are not enough for that, as Greg
occasionally clarified).

And also a few link and reported-by tags to all the bug reports that
apparently are fixed by this change? These are the ones I'm aware of,
there might be more:

https://lore.kernel.org/linux-wireless/CAFktD2fRnSbNgWRRoGbQzG5_Mw7=zFJKTVBHS_3D+mNUYcv9hQ@mail.gmail.com/
https://bugzilla.kernel.org/show_bug.cgi?id=216839
https://bugzilla.kernel.org/show_bug.cgi?id=216844

This indicates that quite a few users are hit by problems this patch
fixes, hence from my point of view it obviously would be ideal if this
patch could make it to mainline quickly.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr

Did I miss something or do something stupid? Then reply and tell me:
https://linux-regtracking.leemhuis.info/about/#stupid

#regzbot ^backmonitor: https://bugzilla.kernel.org/show_bug.cgi?id=216844