Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 3 Jan 2023 18:52:18 +0200
From:   Sicelo <absicsz@gmail.com>
To:     linux-wireless@vger.kernel.org
Cc:     Kalle Valo <kvalo@kernel.org>,
        Johannes Berg <johannes.berg@intel.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Alexander Wetzel <alexander@wetzel-home.de>
Subject: Re: WLAN broken on Nokia N900 with v6.2-rc1
Message-ID: <Y7RdQqBQx58dIMAP@tp440p.steeds.sam>
References: <Y6tTLPvsxh/Im4Ed@tp440p.steeds.sam>
 <a115fbb8-1048-9ae9-fcfb-ac1fd7d33449@wetzel-home.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a115fbb8-1048-9ae9-fcfb-ac1fd7d33449@wetzel-home.de>
Precedence: bulk

Hi Alexander

> 
> I do not yet see how switching the driver to iTXQ can cause the observed
> errors. The warnings above happen during scan, which should not be affected
> by the commit above. So I assume for now that's these are just follow up
> issues and something is wrong before the error messages we get...
> 
> But scanning itself is still working for you? You see the networks, just
> joining them is not working, correct?

Yes, although later I found that joining does actually work, but takes
an unusually long time. I later observed that I can even get an IP
address. However, there is 100% packet loss.

Accidentally, I stumbled on the fact that if I turn power saving off,
then it starts working reasonably well. I am not sure what this
observation suggests though.

> Some ideas how to continue debugging the issue for now:
> 
> 1) Enable debugging and share the all logs starting from driver load up
>    and including one connection request.
>    Looks like you must edit drivers/net/wireless/ti/wl1251/wl1251.h and
>    change line 39:
> 	#define DEBUG_LEVEL (DEBUG_NONE)
>    to
> 	#define DEBUG_LEVEL (DEBUG_ALL)
> 
> 2) Keep debugging enabled but undo the change of the commit causing the
>    problem. Remove the line line 1362 added by the problematic commit in
>    drivers/net/wireless/ti/wl1251/main.c:
> 	.wake_tx_queue = ieee80211_handle_wake_tx_queue,
>    Connection should work again. Run the same test procedure as above
>    and share the debug log from that. with the logs from 1) and 2) we
>    hopefully get an better idea where the problem really is...
> 
> 3) On top of the debug logs above you can also try what happens when we
>    force the driver to use SW scan only:
>    Add the line we removed for 2) again but remove line 1364 instead:
> 	.hw_scan = wl1251_op_hw_scan,
>    Again share the debug logs
> 

I will do further testing in a couple of weeks when I have time again.
Thank you for the suggestions.

Sicelo