Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8a46c9b9-6986-904f-94cc-be4a3cdbf0e6@gmail.com>
Date:   Tue, 3 Jan 2023 21:05:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH 1/2] wifi: rtl8xxxu: Report the RSSI to the firmware
To:     Ping-Ke Shih <pkshih@realtek.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc:     Jes Sorensen <Jes.Sorensen@gmail.com>
References: <6fcaaead-876c-68d1-a049-f1e7f7ff81e7@gmail.com>
 <ec58ba471076464282fdd1ce7d093449@realtek.com>
Content-Language: en-US
From:   Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <ec58ba471076464282fdd1ce7d093449@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/01/2023 10:05, Ping-Ke Shih wrote:
> 
> 
>> -----Original Message-----
>> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> Sent: Saturday, December 31, 2022 12:52 AM
>> To: linux-wireless@vger.kernel.org
>> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>
>> Subject: [PATCH 1/2] wifi: rtl8xxxu: Report the RSSI to the firmware
>>
>> Or in the case of RTL8188EU, report the RSSI to the rate control code.
>>
>> The rate control code for RTL8188EU is less likely to switch to a lower
>> rate when the RSSI is high. The firmware-based rate control in the other
>> chips probably works the same way.
>>
>> This affects all the chips, but it was only tested with RTL8188EU,
>> RTL8188FU, and RTL8192EU.
>>
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>> ---
>>  .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h  | 23 +++++++++++++
>>  .../realtek/rtl8xxxu/rtl8xxxu_8188e.c         |  6 ++++
>>  .../realtek/rtl8xxxu/rtl8xxxu_8188f.c         |  1 +
>>  .../realtek/rtl8xxxu/rtl8xxxu_8192c.c         |  1 +
>>  .../realtek/rtl8xxxu/rtl8xxxu_8192e.c         |  1 +
>>  .../realtek/rtl8xxxu/rtl8xxxu_8723a.c         |  1 +
>>  .../realtek/rtl8xxxu/rtl8xxxu_8723b.c         |  1 +
>>  .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 34 +++++++++++++++++++
>>  8 files changed, 68 insertions(+)
>>
> 
> [...]
> 
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> index fd97c040948a..f5fd3c448587 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
>> @@ -4461,6 +4461,37 @@ void rtl8xxxu_gen2_report_connect(struct rtl8xxxu_priv *priv,
>>  	rtl8xxxu_gen2_h2c_cmd(priv, &h2c, sizeof(h2c.media_status_rpt));
>>  }
>>
>> +void rtl8xxxu_gen1_report_rssi(struct rtl8xxxu_priv *priv, u8 macid, u8 rssi)
>> +{
>> +	struct h2c_cmd h2c;
>> +	const int h2c_size = 3;
> 
> Shouldn't it be 4?
> 
> 		struct {
> 			u8 cmd;
> 			u8 macid;
> 			u8 unknown0;
> 			u8 rssi;  // you fill this field.
> 

I probably copied that from the vendor driver, which doesn't count the
cmd field. But it turns out it doesn't matter. 3 and 4 will have the
same effect here. rtl8xxxu_gen1_h2c_cmd() only checks if the size is
greater than 4 or not.

But I suppose 4 is less confusing, so I'll change it.

>> +
>> +	memset(&h2c, 0, sizeof(struct h2c_cmd));
>> +
>> +	h2c.rssi_report.cmd = H2C_SET_RSSI;
>> +	h2c.rssi_report.macid = macid;
>> +	h2c.rssi_report.rssi = rssi;
>> +
>> +	rtl8xxxu_gen1_h2c_cmd(priv, &h2c, h2c_size);
>> +}
>> +
> 
> [...]
> 
>