Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp12454637rwl; Tue, 3 Jan 2023 14:54:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXtkIIulWKcjQGZ0rLTMfOo0MCVz540a0644Re1I5KyNVw/jrB20KICvkyV+m97yeLq9leRX X-Received: by 2002:a17:907:d38c:b0:83c:1a1e:1efe with SMTP id vh12-20020a170907d38c00b0083c1a1e1efemr38152861ejc.6.1672786489027; Tue, 03 Jan 2023 14:54:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672786489; cv=none; d=google.com; s=arc-20160816; b=pvE/zLUMoJ2Ww8CeYCEsSC9+VMv/ACYdGE7CYg5eZ2O1VWGq2XZaq3NFXS8Jfx+vYq guqLAO9FUdQlcp+ma8r0x3g57sbqOMHsUtDGYiZt7rJn1AiISdzeU/68gJonX2WgLOYq 7ivb2otvPlELyqFiHm8Lx2y3IRJykn27cyoDievrkTgtAoNgoYKt2st/y2eYLcosWaXl imNsRf5i0fX3sSnA3IQidz2tma2ktwyM6z1Xqd6gIX0ckOzA8XyHDvMlqwXw9xZcbJ0d Jr8VAxVVGGyH/+6Ez75rh8boLnL1vjJ0OSi4UHIcxYPlHKgfDYYFx01MtbQ6MG+ZHB6K 3pmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=t6SRd/vdlrZLiE23Ghs9SFQgwkHzgCiX/s8ldc8J8to=; b=FB5GKtuok/3MZqg+dxQ0PiVK2G4DEuqo5i0zfd+HabHM+RTV71uOwM+cQ51N6sp9Ob K1QEL/ddIblr6EjF1pRN3h19sgcSVYJurW4C491KcN8bNRKBWCjAZExY2eMg3URMGXkx 3wFHhm2uBYg739IyHIhKGweXpbdD3nUDxTgcoNTx+ll1MafWwk6KnE9mr/ri4ySGqfZ/ QkSXc10uJVOa52yOyxOZdwum62uKUOX8cfDAry62INLHpHsMkjvqWHESe2o+0ef8YhGG kqH1CaW4Sdnx1jBX9e1T5ryMvy/UMFzwWHdF6Aa9ioEyLTPDrLxXd4d8+dGuKOfp95nd gAXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=epz60bxy; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd5-20020a170907628500b0084c85491fabsi17341293ejc.207.2023.01.03.14.54.32; Tue, 03 Jan 2023 14:54:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=epz60bxy; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233793AbjACWs3 (ORCPT + 67 others); Tue, 3 Jan 2023 17:48:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233187AbjACWs1 (ORCPT ); Tue, 3 Jan 2023 17:48:27 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95A73BC93; Tue, 3 Jan 2023 14:48:26 -0800 (PST) Received: from fedcomp.. (unknown [46.242.14.200]) by mail.ispras.ru (Postfix) with ESMTPSA id C23B0419E9CB; Tue, 3 Jan 2023 22:48:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru C23B0419E9CB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1672786104; bh=t6SRd/vdlrZLiE23Ghs9SFQgwkHzgCiX/s8ldc8J8to=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=epz60bxyKnS0yvAtNuqWFWlT5ilejZAFji8OjEh/6S9mzte6ubz/UskElprl8G1AV Vw6aQlw+F8rhYMOem3LNhyeMfY2vaY+zZL3YTXOI1ftm0DCwapRS555+P1E+pNeFce LMrQfpqE6t+p9sPzvE60eWV0cTBOcdlpHE28Ljdo= From: Fedor Pchelkin To: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Kalle Valo Cc: Fedor Pchelkin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Zekun Shen , Joe Perches , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: Re: [PATCH v2] wifi: ath9k: htc_hst: free skb in ath9k_htc_rx_msg() if there is no callback function Date: Wed, 4 Jan 2023 01:48:15 +0300 Message-Id: <20230103224815.304147-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <87358r49eo.fsf@toke.dk> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > Shouldn't this be 'goto invalid' like all the other error paths in that > function? It should. What is also important: I mistakenly chose kfree_skb() instead of dev_kfree_skb_any() in another patch so I must fix it. Thanks)