Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp1703723rwl; Thu, 5 Jan 2023 18:30:03 -0800 (PST) X-Google-Smtp-Source: AMrXdXu8SZ0jsnbOohnK552Ayx3YWUGCnfbf7qqYTzGMtSosXN/CvmZM31+9kXx2sDXIbfNWBqxg X-Received: by 2002:a17:907:cbc9:b0:7ad:b6d8:c9d0 with SMTP id vk9-20020a170907cbc900b007adb6d8c9d0mr49045254ejc.53.1672972203586; Thu, 05 Jan 2023 18:30:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672972203; cv=none; d=google.com; s=arc-20160816; b=eLUMl1OFo8K4oYHTDemQrXylH3+gxm6aX/T0YfoNzhx0pNkti/KrpEkwIArQ38RClB tpMEkJzsN9sYIQBS4RNeBQAehmYiO/SP4tbQmHtpPxhnFXX9lvxTS+I05EVO5kRLM4FA SOahefTgc7l+dtUKJcc7PZOVl/r4zd6sJ9+3Q3OinSGcvguEqn6ty7dR8zcRe3GW9GiN lHm4euskxQ8TFZb5Q0rL98SZHTtTVl7DhLgSFNJ2n8dzIhUQJB9u2Rs02fikAr1mHPog y4Ri6PxG1W4lRoiUwf1aa1m6AUfeMudwlNjeqcYBaL7Vr7/g2yK8Bx3FF4YJ8r2avxW6 UMSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=b0MS5l12JQXrMhc/ODJiIiyZ57INSl4jxrfHzSM8wB4=; b=kESkdDUUgpkZGJv5ysZWoivuwr1vxLp8/jGznwltlr5z4b11yDo86Pe233sS3oQs5S leYuGYbuEHRjlHzjgAAd+aMargp2zE2OnG9lRNnKKVJemVtSIWWQ7pf8lhIky9N5HTuM PeYik06jLIMknRsdUBStlc6Y7wz2nNKSCoEkooWl6qMTzBjtN29EDGGaHzExxB6bUKDV qKWdSyl0AMP/kW0wtJm5P1ENNaIy/s+SHwURbRSvngrCYo1tFXXurOp0+3v2VBnFiy2z YRl+WWXXQiUMWZZG58rz8ja4qQl6MhOy4n/dizT53lQPGSAHEEEx8fwT0ZZL2SjaOc2J DQwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qb11-20020a1709077e8b00b007ada2ec1a28si37152871ejc.165.2023.01.05.18.29.43; Thu, 05 Jan 2023 18:30:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229441AbjAFC1x (ORCPT + 66 others); Thu, 5 Jan 2023 21:27:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbjAFC1w (ORCPT ); Thu, 5 Jan 2023 21:27:52 -0500 Received: from out30-7.freemail.mail.aliyun.com (out30-7.freemail.mail.aliyun.com [115.124.30.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 152E063F40; Thu, 5 Jan 2023 18:27:50 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0VYxlMJx_1672972055; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VYxlMJx_1672972055) by smtp.aliyun-inc.com; Fri, 06 Jan 2023 10:27:48 +0800 From: Jiapeng Chong To: stf_xl@wp.pl Cc: helmut.schaa@googlemail.com, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH v2] wifi: rt2x00: Remove useless else if Date: Fri, 6 Jan 2023 10:27:31 +0800 Message-Id: <20230106022731.111243-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The assignment of the else and else if branches is the same, so the else if here is redundant, so we remove it. ./drivers/net/wireless/ralink/rt2x00/rt2800lib.c:8927:9-11: WARNING: possible condition with no effect (if == else). Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3631 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- Changes in v2: -Remove useful comment and modify commit message. drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 12b700c7b9c3..1226a883cd67 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c @@ -8924,8 +8924,6 @@ static void rt2800_rxiq_calibration(struct rt2x00_dev *rt2x00dev) if (i < 2 && (bbptemp & 0x800000)) result = (bbptemp & 0xffffff) - 0x1000000; - else if (i == 4) - result = bbptemp; else result = bbptemp; -- 2.20.1.7.g153144c