Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp2138853rwl; Fri, 6 Jan 2023 02:24:16 -0800 (PST) X-Google-Smtp-Source: AMrXdXsLSnTJALn7tzZHU90oi3v92gnVaqpVLriP3z9+Ek0dcXeF+F/BHrsu1pZuG8vR+n/lTSZf X-Received: by 2002:a17:907:c58c:b0:82c:3642:79b5 with SMTP id tr12-20020a170907c58c00b0082c364279b5mr47740065ejc.58.1673000656016; Fri, 06 Jan 2023 02:24:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673000655; cv=none; d=google.com; s=arc-20160816; b=RI5VYwbnyCD2v4+AUvi+Up0hXMBEoe6JcNxRF8TqB45gT9+tBTZzACHPFYM4I3qw9n SOo5Zo7DEtHwJ2Uhx3GTVHpfjf7mwHNxgat5Xv9AlHY1/a17t8K8fjaQI98YBrkyBXts /FNJkdIYjq3XVUSH4cbmXU06JN5OwPsNPPmbSQ2ff8vUi/tA8p6dYoU4OqqjwbUmK/h0 VBMrglp+6ClfoOhLXiYIzL3eOdWz1PFFabTCOglf9kJ+I2U6WCIRAgOfK+Jc9P4XrHJ3 xuk4ov819npg2k5RWOattnp1tMsqcQZHP2IsVx2/UhKDfMpcCgrsY5aZwNGyVphtn7iD qJ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PNw2w9IynA9dhg+0BXAX2mG+8xC0xN3sSjZgRTrUy2k=; b=XDMssfMW1hyVXfiZaqUhnW/VmEx5SyXfrGQtnNHaZfFRCdbOH9ykaGRD1cREByAXkc Xs63vNspNDDYFTQfVrAJn8Jjr1H4TmSkjDXYjtf3ntkjEC7ay0ayCNNNVMI5OwWtvGUH hk0XTk/MyOBol+Pwd7VS5Ggct3xsbADzP/Sl9sTd6Wgvu3NQZ3yknot0tkDr+BXPvkPo 0F5Q8syFX/55yqaSvmh+qSc+V1SlnErTzaa28C39+dLVJkqvxmseJ0cEsBZo69EkHOHa V21DTG6ihmFsmMkA/AkXqjLq7a3TMunQ8UeMlLgInNrFnr2lGecDfJaGeV5/UjpfRSgZ OCWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=HvFKJqvn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w5-20020a50fa85000000b0049243a3d258si1101023edr.389.2023.01.06.02.23.55; Fri, 06 Jan 2023 02:24:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=HvFKJqvn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229928AbjAFKS4 (ORCPT + 66 others); Fri, 6 Jan 2023 05:18:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233760AbjAFKS3 (ORCPT ); Fri, 6 Jan 2023 05:18:29 -0500 Received: from mx4.wp.pl (mx4.wp.pl [212.77.101.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4750D26E8 for ; Fri, 6 Jan 2023 02:18:26 -0800 (PST) Received: (wp-smtpd smtp.wp.pl 15989 invoked from network); 6 Jan 2023 11:18:23 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1673000303; bh=PNw2w9IynA9dhg+0BXAX2mG+8xC0xN3sSjZgRTrUy2k=; h=From:To:Cc:Subject; b=HvFKJqvncCfqqvdgOT31sdIinFMMK4bGhMdyXTLJUqTMIRsozJYlADS/MNdaGjPXF 0ebhJaQpD+M7OkAFN1R3b0d8Rqrjt5FTCuMlHk+tZr69yarOmD5+m/d4CEUoGO//ZS clfVqosQZgQ5rNvQfDY2TErCjDunRjfN1W30UcDY= Received: from 89-64-1-45.dynamic.chello.pl (HELO localhost) (stf_xl@wp.pl@[89.64.1.45]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 6 Jan 2023 11:18:23 +0100 Date: Fri, 6 Jan 2023 11:18:23 +0100 From: Stanislaw Gruszka To: Jiapeng Chong Cc: helmut.schaa@googlemail.com, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH v2] wifi: rt2x00: Remove useless else if Message-ID: <20230106101823.GA994926@wp.pl> References: <20230106022731.111243-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230106022731.111243-1-jiapeng.chong@linux.alibaba.com> X-WP-MailID: 9c2c211b270cb0c6755bfb4135db918b X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [YXO0] X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, Jan 06, 2023 at 10:27:31AM +0800, Jiapeng Chong wrote: > The assignment of the else and else if branches is the same, so the else > if here is redundant, so we remove it. > > ./drivers/net/wireless/ralink/rt2x00/rt2800lib.c:8927:9-11: WARNING: > possible condition with no effect (if == else). > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3631 > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Acked-by: Stanislaw Gruszka