Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   chainofflowers <chainofflowers@posteo.net>
To:     ian.lin@infineon.com
Cc:     Double.Lo@infineon.com, brcm80211-dev-list@broadcom.com,
        brcm80211-dev-list@cypress.com, franky.lin@broadcom.com,
        hante.meuleman@broadcom.com, kvalo@kernel.org,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] brcmfmac: return error when getting invalid max_flowrings
 from dongle
Date:   Sun, 08 Jan 2023 20:53:20 +0000
Message-ID: <4781984.GXAFRqVoOG@luna>
In-Reply-To: <20220929031001.9962-3-ian.lin@infineon.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Hi! This patch:
https://lore.kernel.org/all/20220929031001.9962-3-ian.lin@infineon.com/

causes my Asus PCE-AC88 (1043:86fb) to stop working, because when modprobe 
loads brcmfmac it throws this error:
---
[ 2740.647600] brcmfmac 0000:0d:00.0: brcmf_pcie_init_ringbuffers: invalid 
max_flowrings(264).
---

This is also being reported on reddit:
https://www.reddit.com/r/archlinux/comments/104pqv9/
no_wifi_since_kernel_update_yesterday/

(also, see https://forum.manjaro.org/t/brcmfmac-fails-to-load/131128)

I think that the check on value > 256 is used as a kind of red herring to 
indirectly spot an inconsistent properties report from the PCI bus (?) about 
the network card.
Before that patch, the driver was correctly working for me and I could not 
observe any kernel panic. Maybe, at least in my case, the wrong value was 
still reported but could be safely ignored, as at a later point in time, when 
the card is initialised, everything worked fine.

I am now stuck at kernel 6.1.1, if I upgrade I cannot use the card.
Is there anything I can do to circumvent this issue? May I help somehow with 
debugging & testing? Please let me know...

Thanks,


(c)