Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <efad76dd-14ff-4a36-ec67-fe6f3b8dcc5b@quicinc.com>
Date:   Mon, 9 Jan 2023 17:48:16 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Content-Language: en-US
To:     <johannes@sipsolutions.net>, <linux-wireless@vger.kernel.org>
CC:     <ath11k@lists.infradead.org>
From:   Wen Gong <quic_wgong@quicinc.com>
Subject: authentication timed out by "wifi: mac80211: do link->MLD address
 translation on RX"
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Johannes,

When the rx packet is skb_copy(), the hdr is not re-assign the new skb 
value, and lead the

operation of "translate to MLD addresses" take effect on the original 
skb, and lead

the check "if (!ether_addr_equal(ifmgd->auth_data->ap_addr, 
mgmt->bssid))" fail in ieee80211_rx_mgmt_auth(),

and thus happened "authentication timed out".

After below change, issue not happen again.

--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -4854,6 +4854,8 @@ static bool ieee80211_prepare_and_rx_handle(struct 
ieee80211_rx_data *rx,
                         return true;
                 }

+               hdr = (void *)rx->skb->data;
+
                 /* skb_copy() does not copy the hw timestamps, so copy it
                  * explicitly
                  */


commit:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=42fb9148c078004d07b4c39bd7b1086b6165780c

wifi: mac80211: do link->MLD address translation on RX