Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <598af0e9da276e2e7f03f3a7c2a85e3391333a9d.camel@sipsolutions.net>
Subject: Re: authentication timed out by "wifi: mac80211: do link->MLD
 address translation on RX"
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>, linux-wireless@vger.kernel.org
Cc:     ath11k@lists.infradead.org
Date:   Mon, 09 Jan 2023 11:04:06 +0100
In-Reply-To: <efad76dd-14ff-4a36-ec67-fe6f3b8dcc5b@quicinc.com>
References: <efad76dd-14ff-4a36-ec67-fe6f3b8dcc5b@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

Hi,

On Mon, 2023-01-09 at 17:48 +0800, Wen Gong wrote:
> Hi Johannes,
>=20
> When the rx packet is skb_copy(), the hdr is not re-assign the new skb=
=20
> value, and lead the
>=20
> operation of "translate to MLD addresses" take effect on the original=20
> skb, and lead
>=20
> the check "if (!ether_addr_equal(ifmgd->auth_data->ap_addr,=20
> mgmt->bssid))" fail in ieee80211_rx_mgmt_auth(),
>=20
> and thus happened "authentication timed out".
>=20
> After below change, issue not happen again.
>=20

Yeah ... We found and fixed this, and then a few days later someone else
submitted a patch for it:


https://patchwork.kernel.org/project/linux-wireless/patch/20221208040050.25=
922-1-quic_srirrama@quicinc.com/

johannes