Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230109082514.50747-1-arend.vanspriel@broadcom.com>
In-Reply-To: <20230109082514.50747-1-arend.vanspriel@broadcom.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Mon, 9 Jan 2023 19:21:44 +0900
Message-ID: <CAK7LNAQg6fvHmxRh_GCsV798gC_PY4JGVChLwKzS6V9sRCH0gA@mail.gmail.com>
Subject: Re: [PATCH] scripts: rpm: make clear that mkspec script contains 4.13 feature
To:     Arend van Spriel <arend.vanspriel@broadcom.com>
Cc:     linux-kbuild@vger.kernel.org, linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi.
Thanks for catching this.


On Mon, Jan 9, 2023 at 5:25 PM Arend van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
> A fix was made in the mkspec script [1] that uses a feature, ie. the
> OR expression, which requires RPM 4.13. However, the script indicates
> another minimum version. Lower versions may have success by using
> the --no-deps option as suggested,


As far as I tested, CentOS 7 did not work with --no-deps solution.
It just ended up with a syntax error.


> but feels like bumping the version
> to 4.13 is reasonable as it put me on the wrong track at first with
> RPM 4.11 on my Centos7 machine.
>
> [1] https://lore.kernel.org/linux-kbuild/20221228191014.659746-1-masahiroy@kernel.org/


This is already merged.

Please use

Commit 02a893bc9975 ("kbuild: rpm-pkg: add libelf-devel as alternative
for BuildRequires")

instead of the URL.


>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> ---
>  scripts/package/mkspec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/package/mkspec b/scripts/package/mkspec
> index adab28fa7f89..094e52c979a8 100755
> --- a/scripts/package/mkspec
> +++ b/scripts/package/mkspec
> @@ -1,7 +1,7 @@
>  #!/bin/sh
>  #
>  #      Output a simple RPM spec file.
> -#      This version assumes a minimum of RPM 4.0.3.
> +#      This version assumes a minimum of RPM 4.13
>  #
>  #      The only gothic bit here is redefining install_post to avoid
>  #      stripping the symbols from files in the kernel which we want
> --
> 2.32.0
>


-- 
Best Regards
Masahiro Yamada